[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1610: LUCENE-9384: Backport for field sort optimization

[GitBox <gi...@apache.org>]

mayya-sharipova commented on a change in pull request #1610:
URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r450234884



##########
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##########
@@ -394,6 +399,21 @@ public String toString() {
     return buffer.toString();
   }
 
+
+  /**
+   * For numeric sort fields, setting this field, indicates that
+   * the same numeric data has been indexed with two fields: doc values and points and
+   * that these fields have the same name.
+   * This allows to use sort optimization and skip non-competitive documents.
+   */
+  public void setSkipNonCompetitiveDocs() {

Review comment:
       @jpountz  Do you have suggestions how we should expose sort optimization in 8.x? Are you ok with a proposal to have  a method for `SortField::setCanUsePointsForSort` that when set `true` indicates that the same data is used for indexing points and docValues?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org