[GitHub] [qpid-dispatch] franz1981 commented on a change in pull request #537: DISPATCH-1386 qdr_action_list_t could be replaced by an array of struct q

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #537: DISPATCH-1386 qdr_action_list_t could be replaced by an array of struct q
URL: https://github.com/apache/qpid-dispatch/pull/537#discussion_r324450180
 
 

 ##########
 File path: src/router_core/router_core.c
 ##########
 @@ -101,7 +188,11 @@ void qdr_core_free(qdr_core_t *core)
     // Stop and join the thread
     //
     core->running = false;
-    sys_cond_signal(core->action_cond);
+    sys_mutex_lock(core->action_lock);
+    if (core->sleeping) {
 
 Review comment:
   @kgiusti I forgot to mention that this PR contains an important optimization under load to reduce the signaling work of the worker threads ie to save signaling core if it isn't sleeping. 
   This is beneficial from many point of views although it won't show up on benchmarks: please let me know if I should move it into a separate PR/jira/commit :+1: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org