You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/07/20 14:09:18 UTC
[GitHub] [incubator-yunikorn-release] HuangTing-Yao opened a new pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
HuangTing-Yao opened a new pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19
If you don't want apply CRD when you run `helm install`, you can use `--set installCRD=false` flag .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] HuangTing-Yao commented on pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#issuecomment-661063535
@yangwwei @kingamarton Please help to review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] HuangTing-Yao commented on pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#issuecomment-663341649
@yangwwei OK, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] HuangTing-Yao commented on a change in pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on a change in pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#discussion_r457879412
##########
File path: helm-charts/yunikorn/values.yaml
##########
@@ -16,7 +16,7 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.
-
+installCRD: true
Review comment:
make sense to me. done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#issuecomment-663167662
hi @HuangTing-Yao could you please include the fix you've done for https://github.com/apache/incubator-yunikorn-k8shim/pull/165/files in this PR as well? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei merged pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] kingamarton commented on a change in pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#discussion_r457876457
##########
File path: helm-charts/yunikorn/values.yaml
##########
@@ -16,7 +16,7 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.
-
+installCRD: true
Review comment:
I would disable it by default. Unless until the full feature is implemented. After that we can think about enabling it by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] yangwwei commented on pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#issuecomment-661658594
LGTM. @kingamarton pls take another look. If there is no other comment, I'll commit this tomorrow.
Thanks @HuangTing-Yao for working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [incubator-yunikorn-release] HuangTing-Yao commented on pull request #19: [YUNIKORN-265] Include CRD registration into Helm charts
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-release/pull/19#issuecomment-662963408
@yangwwei Should we close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org