You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Heesung Sohn <he...@streamnative.io.INVALID> on 2022/12/09 22:12:40 UTC
Re: [Discuss] Deprecate Index-based Publisher Stat Aggregation in Topics Partitioned-Stats
Hi,
I raised a PR to the master branch here,
https://github.com/apache/pulsar/pull/18807.
PTAL.
Thank you,
Heesung
On Wed, Nov 30, 2022 at 4:06 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Heesung,
> I also agree that we must preserve compatibility, if we want to pick
> this change to released versions.
> For a new major version we COULD break compatibility only as a last resort.
>
> If we have a way to improve the code and use less resources, I believe
> that it is the best way.
>
> Enrico
>
> Il giorno mer 30 nov 2022 alle ore 11:56 Heesung Sohn
> <he...@streamnative.io.invalid> ha scritto:
> >
> > Hi,
> >
> > I raised this PR to my local fork to sync our direction.
> >
> > https://github.com/heesung-sn/pulsar/pull/15/files
> >
> > Please let me know if this direction looks good. Then, I will proceed to
> > raise an official PR.
> >
> >
> > Thanks,
> > Heesung
>
Re: [Discuss] Deprecate Index-based Publisher Stat Aggregation in Topics Partitioned-Stats
Posted by Heesung Sohn <he...@streamnative.io.INVALID>.
Hi dev,
If there are no particular concerns, I will send out a vote email.
Thanks,
Heesung
On Tue, Jan 3, 2023 at 10:28 AM Heesung Sohn <he...@streamnative.io>
wrote:
> Hi Pulsar dev,
>
> I raised a PIP for the default config change(change the
> aggregatePublisherStatsByProducerName config default to true) as
> requested.
> PIP: https://github.com/apache/pulsar/issues/19125
>
> I guess we can continue to use this discussion thread for this PIP as well.
>
> Thank you,
> Heesung
>
>
> On Fri, Dec 9, 2022 at 2:12 PM Heesung Sohn <he...@streamnative.io>
> wrote:
>
>> Hi,
>>
>> I raised a PR to the master branch here,
>> https://github.com/apache/pulsar/pull/18807.
>>
>> PTAL.
>>
>> Thank you,
>> Heesung
>>
>> On Wed, Nov 30, 2022 at 4:06 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> Heesung,
>>> I also agree that we must preserve compatibility, if we want to pick
>>> this change to released versions.
>>> For a new major version we COULD break compatibility only as a last
>>> resort.
>>>
>>> If we have a way to improve the code and use less resources, I believe
>>> that it is the best way.
>>>
>>> Enrico
>>>
>>> Il giorno mer 30 nov 2022 alle ore 11:56 Heesung Sohn
>>> <he...@streamnative.io.invalid> ha scritto:
>>> >
>>> > Hi,
>>> >
>>> > I raised this PR to my local fork to sync our direction.
>>> >
>>> > https://github.com/heesung-sn/pulsar/pull/15/files
>>> >
>>> > Please let me know if this direction looks good. Then, I will proceed
>>> to
>>> > raise an official PR.
>>> >
>>> >
>>> > Thanks,
>>> > Heesung
>>>
>>
Re: [Discuss] Deprecate Index-based Publisher Stat Aggregation in Topics Partitioned-Stats
Posted by Heesung Sohn <he...@streamnative.io.INVALID>.
Hi Pulsar dev,
I raised a PIP for the default config change(change the
aggregatePublisherStatsByProducerName config default to true) as requested.
PIP: https://github.com/apache/pulsar/issues/19125
I guess we can continue to use this discussion thread for this PIP as well.
Thank you,
Heesung
On Fri, Dec 9, 2022 at 2:12 PM Heesung Sohn <he...@streamnative.io>
wrote:
> Hi,
>
> I raised a PR to the master branch here,
> https://github.com/apache/pulsar/pull/18807.
>
> PTAL.
>
> Thank you,
> Heesung
>
> On Wed, Nov 30, 2022 at 4:06 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> Heesung,
>> I also agree that we must preserve compatibility, if we want to pick
>> this change to released versions.
>> For a new major version we COULD break compatibility only as a last
>> resort.
>>
>> If we have a way to improve the code and use less resources, I believe
>> that it is the best way.
>>
>> Enrico
>>
>> Il giorno mer 30 nov 2022 alle ore 11:56 Heesung Sohn
>> <he...@streamnative.io.invalid> ha scritto:
>> >
>> > Hi,
>> >
>> > I raised this PR to my local fork to sync our direction.
>> >
>> > https://github.com/heesung-sn/pulsar/pull/15/files
>> >
>> > Please let me know if this direction looks good. Then, I will proceed to
>> > raise an official PR.
>> >
>> >
>> > Thanks,
>> > Heesung
>>
>