You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/24 13:08:07 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4862: ui: Display root disk size in Compute offering details
Pearl1594 opened a new pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862
### Description
This PR displays the Root disk size as part of compute offering details if the offering was created with it specified.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
Prior to this fix: When a compute offering is created with root disk size specified, there is not indication of this attribute in the corresponding Compute offering's details.
Post fix:

<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862#discussion_r600530868
##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,11 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item === 'rootdisksize'">
+ <div>
+ {{ parseFloat( resource.rootdisksize / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB
Review comment:
Makes sense.. I can do that. Thanks @GutoVeronezi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862#discussion_r600511819
##########
File path: ui/src/components/view/DetailsTab.vue
##########
@@ -33,6 +33,11 @@
<router-link :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
</div>
</div>
+ <div v-else-if="$route.meta.name === 'computeoffering' && item === 'rootdisksize'">
+ <div>
+ {{ parseFloat( resource.rootdisksize / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB
Review comment:
Suggestion:
I think it would be nice to us to have an utility that centralizes and assures that we always do the same calculation.
@Pearl1594 do you think it would be possible to create an utility to centralize these byte convertions? Like a `getGib(value = 1)` which return `value * 1024 * 1024 * 1024` or `value * GiB` (GiB would be a constant = 1024 * 1024 * 1024).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862#issuecomment-805806165
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862#issuecomment-805805507
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4862: ui: Display root disk size in Compute offering details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4862:
URL: https://github.com/apache/cloudstack/pull/4862#issuecomment-805810008
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4862 (SL-JID-62)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org