You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Pranav Khaitan (JIRA)" <ji...@apache.org> on 2010/07/20 03:03:49 UTC
[jira] Created: (HBASE-2852) Bloom filter NPE
Bloom filter NPE
----------------
Key: HBASE-2852
URL: https://issues.apache.org/jira/browse/HBASE-2852
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Pranav Khaitan
Assignee: Pranav Khaitan
When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892604#action_12892604 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
bq. On 2010-07-26 18:25:37, Jonathan Gray wrote:
bq. > Just a simple null check and added test. LGTM
and all of ryan's comments have been addressed. thanks pranav.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/#review492
-----------------------------------------------------------
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Fix For: 0.90.0
>
> Attachments: HBASE-2852-BloomNPEV3.diff
>
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2852) Bloom filter NPE
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-2852:
---------------------------------
Fix Version/s: 0.90.0
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Fix For: 0.90.0
>
> Attachments: HBASE-2852-BloomNPEV3.diff
>
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2852) Bloom filter NPE
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-2852:
---------------------------------
Attachment: HBASE-2852-BloomNPEV3.diff
Final patch from pranav over on reviewboard to be committed
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Attachments: HBASE-2852-BloomNPEV3.diff
>
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891017#action_12891017 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Pranav Khaitan" <pr...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/
-----------------------------------------------------------
(Updated 2010-07-21 23:04:10.126963)
Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.
Summary
-------
Fixed bloom filter code in StoreFile
This addresses bug HBASE-2852.
http://issues.apache.org/jira/browse/HBASE-2852
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615
Diff: http://review.hbase.org/r/336/diff
Testing
-------
JUnit tests added
Thanks,
Pranav
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890117#action_12890117 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Pranav Khaitan" <pr...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/
-----------------------------------------------------------
Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.
Summary
-------
Fixed bloom filter code in StoreFile
This addresses bug HBASE-2852.
http://issues.apache.org/jira/browse/HBASE-2852
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java PRE-CREATION
Diff: http://review.hbase.org/r/336/diff
Testing
-------
JUnit tests added
Thanks,
Pranav
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890371#action_12890371 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Pranav Khaitan" <pr...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/
-----------------------------------------------------------
(Updated 2010-07-20 11:19:26.615795)
Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.
Changes
-------
Moved the test to TestHRegion
Summary
-------
Fixed bloom filter code in StoreFile
This addresses bug HBASE-2852.
http://issues.apache.org/jira/browse/HBASE-2852
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615
Diff: http://review.hbase.org/r/336/diff
Testing
-------
JUnit tests added
Thanks,
Pranav
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891008#action_12891008 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Ryan Rawson" <ry...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/#review445
-----------------------------------------------------------
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
<http://review.hbase.org/r/336/#comment1872>
you should use initHRegion in this class instead of repeating the boilerplate.
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
<http://review.hbase.org/r/336/#comment1871>
this might not be necessary, since flushcache() returns after the file has been loaded into HRegion/Stores.
- Ryan
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "Pranav Khaitan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892081#action_12892081 ]
Pranav Khaitan commented on HBASE-2852:
---------------------------------------
Thanks for going through the patch. I had updated the patch based on the
latest suggestions. Please let me know if any further changes are required.
Regards,
Pranav
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892599#action_12892599 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/#review492
-----------------------------------------------------------
Ship it!
Just a simple null check and added test. LGTM
- Jonathan
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Attachments: HBASE-2852-BloomNPEV3.diff
>
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2852) Bloom filter NPE
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890129#action_12890129 ]
HBase Review Board commented on HBASE-2852:
-------------------------------------------
Message from: "Ryan Rawson" <ry...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/336/#review425
-----------------------------------------------------------
trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java
<http://review.hbase.org/r/336/#comment1794>
can you rework this test not to use TEST_UTIL and starting up a mini-hbase cluster?
For alternate options, try doing what HRegion does, which is to instantiate a HRegion then use the HRegion API calls instead.
- Ryan
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2852) Bloom filter NPE
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray resolved HBASE-2852.
----------------------------------
Resolution: Fixed
Committed to trunk. Thanks pranav.
> Bloom filter NPE
> ----------------
>
> Key: HBASE-2852
> URL: https://issues.apache.org/jira/browse/HBASE-2852
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Pranav Khaitan
> Assignee: Pranav Khaitan
> Attachments: HBASE-2852-BloomNPEV3.diff
>
>
> When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.