You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/06 21:44:52 UTC
[GitHub] [kafka] guozhangwang opened a new pull request, #12259: HOTFIX: only try to clear discover-coordinator future upon commit
guozhangwang opened a new pull request, #12259:
URL: https://github.com/apache/kafka/pull/12259
This is a cherrypick commit of 3.1. Another way of fixing [KAFKA-13563](https://issues.apache.org/jira/browse/KAFKA-13563) other than https://github.com/apache/kafka/pull/11631.
Instead of letting the consumer to always try to discover coordinator in pool with either mode (subscribe / assign), we defer the clearance of discover future upon committing async only. More specifically, under manual assign mode, there are only three places where we need the coordinator:
* commitAsync (both by the consumer itself or triggered by caller), this is where we want to fix.
* commitSync, which we already try to re-discovery coordinator.
* committed (both by the consumer itself based on reset policy, or triggered by caller), which we already try to re-discovery coordinator.
The benefits are that for manual assign mode that does not try to trigger any of the above three, then we never would be discovering coordinator. The original fix in https://github.com/apache/kafka/pull/11631 would let the consumer to discover coordinator even if none of the above operations are required.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #12259: HOTFIX: only try to clear discover-coordinator future upon commit
Posted by GitBox <gi...@apache.org>.
ijuma merged PR #12259:
URL: https://github.com/apache/kafka/pull/12259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org