You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/04/24 12:30:50 UTC
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24235
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
The test measures the duration of GetOperationStatus after submitting a
query that runs longer than 80ms. The main goal of the test is verifying
GetOperationStatus returns immediately after the query state becomes
FINISHED. It also verifies the duration of GetOperationStatus is longer
than 80ms. This is flaky since the query might already be running when
the GetOperationStatus request is submitted. On the other hand, FINISHED
state just means client can start fetching results. Some result rows
might not be generated yet so we can't guarantee the GetOperationStatus
duration is longer than 80ms.
This simply removes the lower bound check on 80ms.
Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
---
M tests/hs2/test_hs2.py
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/24235/1
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 05:17:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
The test measures the duration of GetOperationStatus after submitting a
query that runs longer than 80ms. The main goal of the test is verifying
GetOperationStatus returns immediately after the query state becomes
FINISHED. It also verifies the duration of GetOperationStatus is longer
than 80ms. This is flaky since the query might already be running when
the GetOperationStatus request is submitted. On the other hand, FINISHED
state just means client can start fetching results. Some result rows
might not be generated yet so we can't guarantee the GetOperationStatus
duration is longer than 80ms.
This simply removes the lower bound check on 80ms.
Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Reviewed-on: http://gerrit.cloudera.org:8080/24235
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/hs2/test_hs2.py
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22231/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 12:53:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13382/
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 25 Apr 2026 03:57:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 17:07:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13382/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 23:36:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> I'm also changing the upper bound here: https://gerrit.cloudera.org/#/c/24225/
> But we can go ahead with this piece.
Sure. Thanks for the quick review!
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 23:35:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 23:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 1: Code-Review+2
I'm also changing the upper bound here: https://gerrit.cloudera.org/#/c/24225/
But we can go ahead with this piece.
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Apr 2026 23:29:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test long polling success
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24235 )
Change subject: IMPALA-14920: Remove lower bound check on GetOperationStatus duration in test_long_polling_success
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13386/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5047626b10d4c1e6489b41b6da6c4906cd62ca1b
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 00:58:58 +0000
Gerrit-HasComments: No