[GitHub] heyile commented on a change in pull request #861: [SCB-612]delete useless MicroserviceMetaManager

[GitBox <gi...@apache.org>]

heyile commented on a change in pull request #861: [SCB-612]delete useless MicroserviceMetaManager
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r208820006
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
 ##########
 @@ -74,12 +71,22 @@ public void notifySchemaListener(List<SchemaMeta> schemaMetaList) {
   }
 
   public SchemaMeta ensureFindSchemaMeta(String microserviceName, String schemaId) {
-    MicroserviceMeta microserviceMeta = microserviceMetaManager.ensureFindValue(microserviceName);
+    if (!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
+      LOGGER.error("miroserviceName : {} is different from the default microserviceName :{}",
 
 Review comment:
   this logic will not happen in the normal mode , and I have asked jimin about whether I could delete parameter microserviceName because it's no use now. He suggested me to keep it for the compatibility of the method with 
   other classes or modules and he advised me to compare the parameter microserviceName with the default right micorserviceName. just make sure the program is running as we expected。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services