[GitHub] [geode] sabbey37 edited a comment on pull request #6676: GEODE-9416: Bump tomcat8 from 8.5.66 to 8.5.69

[GitBox <gi...@apache.org>]

sabbey37 edited a comment on pull request #6676:
URL: https://github.com/apache/geode/pull/6676#issuecomment-875865663


   There was [a change](https://github.com/apache/tomcat/commit/f488fb08f8204126da79fd9d333c04d1ad936567#diff-7a7bd66ef966a17eca71b8f32e9bf763cb7f5ea7d45fad121453011f3824f412R1417) between Tomcat versions 8.5.66 and 8.5.67 as well as between 9.0.20 and 9.0.21 that resulted in an NPE being throw in `setAttribute`.  This issue was found and resolved by [GEODE-7896](https://issues.apache.org/jira/browse/GEODE-7896) and included in these Geode versions: 1.12.2, 1.13.3, 1.14.0+.  However, these upgrade tests pull in the most recent version of the Tomcat dependency (as specified in `TomcatInstall.java`), even though earlier versions of Geode used earlier versions of Tomcat that did not include this change.
   
   @onichols-pivotal if you know of a better way of making sure older versions of Geode pull in their corresponding versions of Tomcat or if you think we should spend some time investigating this, please let us know!  We are working on improving these tests as well as adding the same tests for Tomcat 9.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org