[GitHub] [incubator-pinot] haibow commented on a change in pull request #4669: Update realtime segment manager

[GitBox <gi...@apache.org>]

haibow commented on a change in pull request #4669: Update realtime segment manager
URL: https://github.com/apache/incubator-pinot/pull/4669#discussion_r330765468
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
 ##########
 @@ -1141,7 +1140,7 @@ public LLRealtimeSegmentDataManager(RealtimeSegmentZKMetadata segmentZKMetadata,
     // Start new realtime segment
     RealtimeSegmentConfig.Builder realtimeSegmentConfigBuilder =
         new RealtimeSegmentConfig.Builder().setSegmentName(_segmentNameStr).setStreamName(_streamTopic)
-            .setSchema(schema).setCapacity(_segmentMaxRowCount)
+            .setSchema(_schema).setCapacity(_segmentMaxRowCount)
 
 Review comment:
   Some more context:
   `_schema` assigned to `schema` in 
   line 1072: `_schema = schema;`
   
   `_schema` used in some other places:
   line 1102: `if (_schema.hasColumn(firstSortedColumn)) {`
   line 1154: `_messageDecoder = StreamDecoderProvider.create(_partitionLevelStreamConfig, _schema);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org