[jira] [Commented] (AIRFLOW-6255) Redis Hook - refactor & add most important methods

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996551#comment-16996551 ] 

ASF GitHub Bot commented on AIRFLOW-6255:
-----------------------------------------

mgorsk1 commented on pull request #6820: [AIRFLOW-6255] Redis Hook Refactor
URL: https://github.com/apache/airflow/pull/6820
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [V] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [V] Here are some details about my PR, including screenshots of any UI changes:
   This PR aims to refactor Redis Hook and all classes (sensors/operators) which are using it. So far every component used Redis Hook by interfacing directly with redis client. This change adds dedicated hook methods to interact with Redis and moves away from interfacing with redis client directly.
   
   ### Tests
   
   - [V] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   I've extended tests/contrib/hooks/test_redis_hook.py and refactored tests/contrib/operators/test_redis_pub_sub_operator.py, tests/contrib/sensors/test_redis_sensor.py and tests/contrib/sensors/test_redis_pub_sub_sensor.py to align with added hook methods. 
   
   ### Commits
   
   - [V] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [V] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Redis Hook - refactor & add most important methods
> --------------------------------------------------
>
>                 Key: AIRFLOW-6255
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6255
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.6
>            Reporter: Mariusz Górski
>            Assignee: Mariusz Górski
>            Priority: Minor
>              Labels: hooks, redis, refactor
>
> Currently Redis Hook consists of get_conn func only and every operation using it is calling Redis client methods directly. This Issue aims to extend Redis Hook so it provides all necessary methods wrapping Redis functionality used so far.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)