[GitHub] spark pull request #23160: [SPARK-26196][WebUI] Total tasks title in the sta...

[pgandhi999 <gi...@git.apache.org>]

Github user pgandhi999 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23160#discussion_r237843584
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js ---
    @@ -610,7 +610,8 @@ $(document).ready(function () {
                     $("#accumulator-table").DataTable(accumulatorConf);
     
                     // building tasks table that uses server side functionality
    -                var totalTasksToShow = responseBody.numCompleteTasks + responseBody.numActiveTasks;
    +                var totalTasksToShow = responseBody.numCompleteTasks + responseBody.numActiveTasks +
    --- End diff --
    
    Ah that makes sense. Looks good to me, however could you also please verify whether the data in tasks table reflects information about the failed / killed tasks as well, as I am passing the value of that variable in the ajax request while fetching data for task tables. Thank you for catching that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org