Please review patch + more

[Miguel Griffa <mg...@technisys.net>]

Hi all, in my every day work I really need the fix for the issue

    http://jira.codehaus.org/browse/MPJAR-20

I sent the patch, could anyone apply it if it is correct?

On the other hand, I've seen several patches (some mine, some from 
others) on the eclipse plugin without response, I think it would be 
really good for the community to (in general) review patches quiclkly, 
even if it is to bounce them, it's still better than the feelling of 
being ignored...

Please do not misintepret me (bad english?) I'm just saying that I like 
very much maven, I like to contribute, I'd like to contribute even more 
in the future, but not having response is quite dissapointing, It makes 
me feel like 'you have nothing to contribute here, go somewhere else'. 
May be it's just a bad time, before the stable release, may be I'm 
wrong, and maybe there's a little truth in every aspect.

Anyway, thanks for a great product, I really hope to be able to 
contribute more, and I'd really like to see the community grow fast and 
healthy.
Cheers
Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: Please review patch + more

[Miguel Griffa <mg...@technisys.net>]

Brett Porter wrote:

>>On the other hand, I've seen several patches (some mine, some from 
>>others) on the eclipse plugin without response, I think it would be 
>>really good for the community to (in general) review patches quiclkly, 
>>even if it is to bounce them, it's still better than the feelling of 
>>being ignored...
>>    
>>
>Reminding after a few days is the best way to go about it, just remember that
>there are very limited resources.
>  
>
good to know this, I'll apply it

>  
>
>>in the future, but not having response is quite dissapointing, It makes 
>>me feel like 'you have nothing to contribute here, go somewhere else'. 
>>May be it's just a bad time, before the stable release, may be I'm 
>>wrong, and maybe there's a little truth in every aspect.
>>    
>>
>
>That's pretty much the reason :) Don't be offended.
>  
>
good to know, I'll try to help as much as I can then

>- Brett
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>  
>


-- 

Miguel Griffa
Software Architect
Technisys.NET  "The First Digital e-nabler"
Transactional Solutions

Miami +1 305 357 8109
Madrid +34 915 726 763
Buenos Aires: +54 11 43227100
mgriffa@technisys.net
http://www.technisys.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: Please review patch + more

[Brett Porter <br...@apache.org>]

>     http://jira.codehaus.org/browse/MPJAR-20
> 
> I sent the patch, could anyone apply it if it is correct?

I'll take a look at my current round of work.

> On the other hand, I've seen several patches (some mine, some from 
> others) on the eclipse plugin without response, I think it would be 
> really good for the community to (in general) review patches quiclkly, 
> even if it is to bounce them, it's still better than the feelling of 
> being ignored...

Reminding after a few days is the best way to go about it, just remember that
there are very limited resources.

> in the future, but not having response is quite dissapointing, It makes 
> me feel like 'you have nothing to contribute here, go somewhere else'. 
> May be it's just a bad time, before the stable release, may be I'm 
> wrong, and maybe there's a little truth in every aspect.

That's pretty much the reason :) Don't be offended.

- Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org