[GitHub] [iceberg] fbocse commented on a change in pull request #2012: Fix small issues

[GitBox <gi...@apache.org>]

fbocse commented on a change in pull request #2012:
URL: https://github.com/apache/iceberg/pull/2012#discussion_r551342792



##########
File path: core/src/main/java/org/apache/iceberg/ScanSummary.java
##########
@@ -305,7 +305,7 @@ public String toString() {
   private static class TopN<K, V> {
     private final int maxSize;
     private final boolean throwIfLimited;
-    private final SortedMap<K, V> map;
+    private final NavigableMap<K, V> map;

Review comment:
       Curious to what the issue that this change fixes? I'm asking cause I'm not really that knowledgeable when it comes to these java collections in particular, all I know is that SortedMap is a superinterface of NavigableMap, and since I'm generally guided by using the least specific interface "principle" I was wondering why that wouldn't apply in this case as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org