You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Haihui Xu <sz...@163.com> on 2017/03/23 08:32:02 UTC
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated \u4e09\u6708 23, 2017, 8:32 a.m.)
Review request for ranger and VaradreawiZTV VaradreawiZTV.
Summary (updated)
-----------------
Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Repository: ranger
Description (updated)
-------
1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
2.Web UI's Settings Permissions tab, click action to edit permission, and the page display bellow 'Edit Permission' is 'Policy Details' (0.6.3 version), 'Module Details'(0.7.0 version ,1.0.0 version). The action is 'edit permission',so 'Permission Details' or 'Module Permission Details' may be more reasonable.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
Diff: https://reviews.apache.org/r/57868/diff/1/
Testing
-------
Page Display, test ok.
File Attachments
----------------
RANGER-1411-0.6.3.patch
https://reviews.apache.org/media/uploaded/files/2017/03/23/6b59ee99-c8bb-4458-badb-faf8b7e87f66__RANGER-1411-0.6.3.patch
RANGER-1411-0.7.0.patch
https://reviews.apache.org/media/uploaded/files/2017/03/23/9af2e730-7030-42c9-8e61-8d3fbb0f53a9__RANGER-1411-0.7.0.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175245
-----------------------------------------------------------
Please create the patch using "git format-patch..."
- Colm O hEigeartaigh
On May 17, 2017, 1:18 p.m., Haihui Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 1:18 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1411
> https://issues.apache.org/jira/browse/RANGER-1411
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
> security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
>
>
> Diff: https://reviews.apache.org/r/57868/diff/1/
>
>
> Testing
> -------
>
> Page Display, test ok.
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
>
>
> Thanks,
>
> Haihui Xu
>
>
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175362
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 18, 2017, 1:26 a.m., Haihui Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 1:26 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1411
> https://issues.apache.org/jira/browse/RANGER-1411
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 49d0323
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
>
>
> Diff: https://reviews.apache.org/r/57868/diff/2/
>
>
> Testing
> -------
>
> Page Display, test ok.
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
>
>
> Thanks,
>
> Haihui Xu
>
>
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Haihui Xu <sz...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated 五月 18, 2017, 1:26 a.m.)
Review request for ranger.
Bugs: RANGER-1411
https://issues.apache.org/jira/browse/RANGER-1411
Repository: ranger
Description
-------
Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 49d0323
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
Diff: https://reviews.apache.org/r/57868/diff/2/
Changes: https://reviews.apache.org/r/57868/diff/1-2/
Testing
-------
Page Display, test ok.
File Attachments
----------------
0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Haihui Xu <sz...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated 五月 17, 2017, 1:18 p.m.)
Review request for ranger.
Changes
-------
upload a new patch
Bugs: RANGER-1411
https://issues.apache.org/jira/browse/RANGER-1411
Repository: ranger
Description
-------
Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
Diff: https://reviews.apache.org/r/57868/diff/1/
Testing
-------
Page Display, test ok.
File Attachments (updated)
----------------
0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175231
-----------------------------------------------------------
There is a comma ',' missing after 'Modules' in security-admin/src/main/webapp/scripts/modules/globalize/message/en.js.
By the way you can just update the diff rather than add files to the review request.
- Colm O hEigeartaigh
On May 17, 2017, 8:35 a.m., Haihui Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 8:35 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1411
> https://issues.apache.org/jira/browse/RANGER-1411
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
> security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
>
>
> Diff: https://reviews.apache.org/r/57868/diff/1/
>
>
> Testing
> -------
>
> Page Display, test ok.
>
>
> File Attachments
> ----------------
>
> RANGER-1411.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
> 0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
>
>
> Thanks,
>
> Haihui Xu
>
>
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Haihui Xu <sz...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated 五月 17, 2017, 8:35 a.m.)
Review request for ranger.
Bugs: RANGER-1411
https://issues.apache.org/jira/browse/RANGER-1411
Repository: ranger
Description
-------
Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
Diff: https://reviews.apache.org/r/57868/diff/1/
Testing
-------
Page Display, test ok.
File Attachments (updated)
----------------
RANGER-1411.patch
https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
https://reviews.apache.org/media/uploaded/files/2017/05/17/2ad83ef8-56bf-4922-83f6-8d254bdd673e__0001-RANGER-1411-Permissions-tab-pages-display-are-not-re.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175099
-----------------------------------------------------------
Please submit a patch for "master" only. Also the latest patch still has the "Permissions Details" change in it.
When you are submitting a patch, please use " git format-patch -n HEAD~" as per:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244
- Colm O hEigeartaigh
On May 16, 2017, 1:47 p.m., Haihui Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 1:47 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1411
> https://issues.apache.org/jira/browse/RANGER-1411
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
> security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
>
>
> Diff: https://reviews.apache.org/r/57868/diff/1/
>
>
> Testing
> -------
>
> Page Display, test ok.
>
>
> File Attachments
> ----------------
>
> RANGER-1411.patch
> https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
>
>
> Thanks,
>
> Haihui Xu
>
>
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Haihui Xu <sz...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated May 16, 2017, 1:47 p.m.)
Review request for ranger.
Bugs: RANGER-1411
https://issues.apache.org/jira/browse/RANGER-1411
Repository: ranger
Description
-------
Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
Diff: https://reviews.apache.org/r/57868/diff/1/
Testing
-------
Page Display, test ok.
File Attachments
----------------
RANGER-1411.patch
https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Haihui Xu <sz...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
-----------------------------------------------------------
(Updated 五月 16, 2017, 6:35 a.m.)
Review request for ranger.
Changes
-------
delete point (2).
Repository: ranger
Description (updated)
-------
Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
Diff: https://reviews.apache.org/r/57868/diff/1/
Testing
-------
Page Display, test ok.
File Attachments (updated)
----------------
RANGER-1411.patch
https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
Thanks,
Haihui Xu
Re: Review Request 57868: Permissions tab pages display are not
reasonable.https://issues.apache.org/jira/browse/RANGER-1411
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review174616
-----------------------------------------------------------
I agree with point (1). However, for point (2) I feel that "Module Details" is fine, as the page lists the module name + then user/group permissions. Could you resubmit a patch with just the first change?
- Colm O hEigeartaigh
On March 23, 2017, 8:32 a.m., Haihui Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 8:32 a.m.)
>
>
> Review request for ranger.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions table header is Permissions,Groups,Users,Action. But the first column in the table is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table header should be Modules,Groups,Users,Action.
> 2.Web UI's Settings Permissions tab, click action to edit permission, and the page display bellow 'Edit Permission' is 'Policy Details' (0.6.3 version), 'Module Details'(0.7.0 version ,1.0.0 version). The action is 'edit permission',so 'Permission Details' or 'Module Permission Details' may be more reasonable.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 7a4b82c
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 92c07c7
> security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html 909d2fc
>
>
> Diff: https://reviews.apache.org/r/57868/diff/1/
>
>
> Testing
> -------
>
> Page Display, test ok.
>
>
> File Attachments
> ----------------
>
> RANGER-1411-0.6.3.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/23/6b59ee99-c8bb-4458-badb-faf8b7e87f66__RANGER-1411-0.6.3.patch
> RANGER-1411-0.7.0.patch
> https://reviews.apache.org/media/uploaded/files/2017/03/23/9af2e730-7030-42c9-8e61-8d3fbb0f53a9__RANGER-1411-0.7.0.patch
>
>
> Thanks,
>
> Haihui Xu
>
>