You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/03/15 17:30:07 UTC
[GitHub] [pinot] walterddr opened a new issue, #10428: flagging columns null instead of null from table config
walterddr opened a new issue, #10428:
URL: https://github.com/apache/pinot/issues/10428
currently enabled null support is a table-level configuration. we need to create column-level null support to indicate whether a column is nullable.
This:
1. enables calcite to generate more efficient plan when column is non-nullable.
2. provide runtime better boxing/unboxing optimization, currently everything need to handle in generic fashion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #10428: flagging columns null instead of null from table config
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #10428:
URL: https://github.com/apache/pinot/issues/10428#issuecomment-1470899724
We can add a boolean variable `_nullable` in the `FieldSpec` to indicate whether we should create `NullVector` for the column. For backward compatibility, when the table level configuration is enabled, we can set all fields as `nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10428: flagging columns null instead of null from table config
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10428:
URL: https://github.com/apache/pinot/issues/10428#issuecomment-1470463869
CC @Jackie-Jiang @ankitsultana @61yao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10428: flagging columns null instead of null from table config
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10428:
URL: https://github.com/apache/pinot/issues/10428#issuecomment-1470941633
> We can add a boolean variable `_nullable` in the `FieldSpec` to indicate whether we should create `NullVector` for the column. For backward compatibility, when the table level configuration is enabled, we can set all fields as `nullable`
+1 that's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org