You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/17 19:19:55 UTC

[kudu-CR](branch-1.11.x) [common] Use EncodeKeyImpl() to handle different RowType 

Hello Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14492

to review the following change.


Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................

[common] Use EncodeKeyImpl() to handle different RowType

For different RowType, the processing logic in two overloaded
EncodeRow() is duplicated.

Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Reviewed-on: http://gerrit.cloudera.org:8080/14461
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit eedcbb1bffa32ee25573673ae55db27118d1d732)
---
M src/kudu/common/partition.cc
1 file changed, 7 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/14492/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>

[kudu-CR](branch-1.11.x) [common] Use EncodeKeyImpl() to handle different RowType

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14492 )

Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................

[common] Use EncodeKeyImpl() to handle different RowType

For different RowType, the processing logic in two overloaded
EncodeRow() is duplicated.

Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Reviewed-on: http://gerrit.cloudera.org:8080/14461
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit eedcbb1bffa32ee25573673ae55db27118d1d732)
Reviewed-on: http://gerrit.cloudera.org:8080/14492
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/common/partition.cc
1 file changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14492
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.11.x) [common] Use EncodeKeyImpl() to handle different RowType

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14492 )

Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 20:25:40 +0000
Gerrit-HasComments: No