You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/08/26 08:23:36 UTC

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12963: [Issue 10331] Fresh Docker install results in "Uh... I have no servers. Not assigning anything...

abhishekagarwal87 commented on code in PR #12963:
URL: https://github.com/apache/druid/pull/12963#discussion_r955789625


##########
distribution/docker/druid.sh:
##########
@@ -50,6 +51,27 @@ test -d /tmp/conf/druid && rm -r /tmp/conf/druid
 cp -r /opt/druid/conf/druid /tmp/conf/druid
 
 getConfPath() {
+    if [ -n "$DRUID_SINGLE_NODE_CONF" ]
+    then
+      getSingleServerConfPath $1
+    else
+      getClusterConfPath $1
+    fi
+}
+getSingleServerConfPath() {
+    cluster_conf_base=/tmp/conf/druid/single-server
+    case "$1" in
+    _common) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/_common ;;
+    historical) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/historical ;;
+    middleManager) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/middleManager ;;
+#    indexer) echo $cluster_conf_base/data/indexer ;;
+    coordinator | overlord) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/coordinator-overlord ;;
+    broker) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/broker ;;
+    router) echo $cluster_conf_base/$DRUID_SINGLE_NODE_CONF/router ;;
+    *) echo $cluster_conf_base/misc/$1 ;;

Review Comment:
   nit:
   ```suggestion
       single_node_conf_base=/tmp/conf/druid/single-server/$DRUID_SINGLE_NODE_CONF
       case "$1" in
       _common) echo $single_node_conf_base/_common ;;
       historical) echo $single_node_conf_base/historical ;;
       middleManager) echo $single_node_conf_base/middleManager ;;
       coordinator | overlord) echo $single_node_conf_base/coordinator-overlord ;;
       broker) echo $single_node_conf_base/broker ;;
       router) echo $single_node_conf_base/router ;;
       *) echo $single_node_conf_base/misc/$1 ;;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org