You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/06 20:24:41 UTC
Review Request 36216: Only run netcat tests when nc is available.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
Repository: mesos
Description
-------
nc is not available on CentOS 7.1 and all the tests using nc will fail.
Added a new NetcatFilter so we detect nc before running these tests.
Diffs
-----
src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
src/tests/environment.cpp 3726e5d95b9388f0881184e1b4874e1eb2e7f531
src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb
Diff: https://reviews.apache.org/r/36216/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 36216: Only run netcat tests when nc is available.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/#review90597
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36216]
All tests passed.
- Mesos ReviewBot
On July 6, 2015, 8:40 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36216/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 8:40 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2996
> https://issues.apache.org/jira/browse/MESOS-2996
>
>
> Repository: mesos
>
>
> Description
> -------
>
> nc is not available on CentOS 7.1 and all the tests using nc will fail.
> Added a new NetcatFilter so we detect nc before running these tests.
>
>
> Diffs
> -----
>
> src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
> src/tests/environment.cpp 3726e5d95b9388f0881184e1b4874e1eb2e7f531
> src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb
>
> Diff: https://reviews.apache.org/r/36216/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 36216: Only run netcat tests when nc is available.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/
-----------------------------------------------------------
(Updated July 6, 2015, 8:40 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.
Bugs: MESOS-2996
https://issues.apache.org/jira/browse/MESOS-2996
Repository: mesos
Description
-------
nc is not available on CentOS 7.1 and all the tests using nc will fail.
Added a new NetcatFilter so we detect nc before running these tests.
Diffs
-----
src/tests/docker_containerizer_tests.cpp d4ccb0b30fe27980846d913e292d2e18fd3d1055
src/tests/environment.cpp 3726e5d95b9388f0881184e1b4874e1eb2e7f531
src/tests/port_mapping_tests.cpp ac49cdfdcf6baf00ac2907e193c683c8b6c83ffb
Diff: https://reviews.apache.org/r/36216/diff/
Testing
-------
make check
Thanks,
Timothy Chen