You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/09/02 09:48:44 UTC
[jira] Commented: (HADOOP-4046) WritableComparator's constructor
should be protected instead of private
[ https://issues.apache.org/jira/browse/HADOOP-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627595#action_12627595 ]
Hadoop QA commented on HADOOP-4046:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389315/4046-0.patch
against trunk revision 691099.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/console
This message is automatically generated.
> WritableComparator's constructor should be protected instead of private
> -----------------------------------------------------------------------
>
> Key: HADOOP-4046
> URL: https://issues.apache.org/jira/browse/HADOOP-4046
> Project: Hadoop Core
> Issue Type: Bug
> Components: io
> Affects Versions: 0.18.0
> Reporter: Owen O'Malley
> Assignee: Chris Douglas
> Fix For: 0.18.1
>
> Attachments: 4046-0.patch
>
>
> Currently, it isn't possible to subclass WritableComparator in a meaningful way. We should make this constructor protected:
> {code}
> private WritableComparator(Class keyClass, boolean createInstances)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.