You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/26 18:57:35 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3956: Use Arc inside Field (#3955)
tustvold opened a new pull request, #3956:
URL: https://github.com/apache/arrow-rs/pull/3956
_Draft as I am not sure about this_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #3955
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Allows for cheaper cloning of DataType and potentially faster comparisons, by comparing pointers instead of string contents
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] crepererum commented on pull request #3956: Use Arc inside Field (#3955)
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #3956:
URL: https://github.com/apache/arrow-rs/pull/3956#issuecomment-1486874182
> hold a `FieldRef` rather than just the name
That's not always possible, since you may not have the datatype at hand yet. So at least during logical planning in DF this ain't an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3956: Use Arc inside Field (#3955)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3956:
URL: https://github.com/apache/arrow-rs/pull/3956#issuecomment-1487120641
> That's not always possible, since you may not have the datatype at hand yet. So at least during logical planning in DF this ain't an option.
🤔 I think as soon as DataFusion creates a `LogicalPlan` / `Expr` it is possible to get the type using https://docs.rs/datafusion/latest/datafusion/prelude/enum.Expr.html#impl-ExprSchemable-for-Expr
Or more to the point, with a LogicalPlan you also have a `Schema` with `Field`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #3956: Use Arc inside Field (#3955)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #3956:
URL: https://github.com/apache/arrow-rs/pull/3956#issuecomment-1486834377
I think if we Arc the entire Field -- as in https://github.com/apache/arrow-rs/pull/3965 we may not need this
I know that @crepererum has mentioned other downstream places that copy the field name (like Statistics in DataFusion) but I think maybe a better design would be to update those downstream uses to hold a `FieldRef` rather than just the name 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed pull request #3956: Use Arc inside Field (#3955)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #3956: Use Arc<str> inside Field (#3955)
URL: https://github.com/apache/arrow-rs/pull/3956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3956: Use Arc inside Field (#3955)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3956:
URL: https://github.com/apache/arrow-rs/pull/3956#issuecomment-1486840717
Agreed, my plan is to see what return we get from #3965 and then revisit this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3956: Use Arc inside Field (#3955)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3956:
URL: https://github.com/apache/arrow-rs/pull/3956#issuecomment-1488300496
Going to close this for now to clear up the review backlog slightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org