You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/11/09 21:58:57 UTC
Review Request: Need to move oauth2.json to shindig-gadget
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2793/
-----------------------------------------------------------
Review request for shindig, Matt Marum, Eric Woods, and Adam Clarke.
Summary
-------
pom.xml is fixed to copy over oauth2.json
This addresses bug SHINDIG-1658.
https://issues.apache.org/jira/browse/SHINDIG-1658
Diffs
-----
/trunk/java/gadgets/pom.xml 1198987
Diff: https://reviews.apache.org/r/2793/diff
Testing
-------
passed junits, project builds
Thanks,
li
Re: Review Request: Need to move oauth2.json to shindig-gadget
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2793/#review3138
-----------------------------------------------------------
Ship it!
LGTM.
- Matt
On 2011-11-09 20:58:57, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2793/
> -----------------------------------------------------------
>
> (Updated 2011-11-09 20:58:57)
>
>
> Review request for shindig, Matt Marum, Eric Woods, and Adam Clarke.
>
>
> Summary
> -------
>
> pom.xml is fixed to copy over oauth2.json
>
>
> This addresses bug SHINDIG-1658.
> https://issues.apache.org/jira/browse/SHINDIG-1658
>
>
> Diffs
> -----
>
> /trunk/java/gadgets/pom.xml 1198987
>
> Diff: https://reviews.apache.org/r/2793/diff
>
>
> Testing
> -------
>
> passed junits, project builds
>
>
> Thanks,
>
> li
>
>
Re: Review Request: Need to move oauth2.json to shindig-gadget
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2793/#review3139
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2011-11-09 20:58:57, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2793/
> -----------------------------------------------------------
>
> (Updated 2011-11-09 20:58:57)
>
>
> Review request for shindig, Matt Marum, Eric Woods, and Adam Clarke.
>
>
> Summary
> -------
>
> pom.xml is fixed to copy over oauth2.json
>
>
> This addresses bug SHINDIG-1658.
> https://issues.apache.org/jira/browse/SHINDIG-1658
>
>
> Diffs
> -----
>
> /trunk/java/gadgets/pom.xml 1198987
>
> Diff: https://reviews.apache.org/r/2793/diff
>
>
> Testing
> -------
>
> passed junits, project builds
>
>
> Thanks,
>
> li
>
>