You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/28 13:19:23 UTC
[GitHub] [arrow] kszucs opened a new pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
kszucs opened a new pull request #8289:
URL: https://github.com/apache/arrow/pull/8289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs removed a comment on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs removed a comment on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700011652
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700978155
Revision: 66a09002b2dbea7d15ed2dcef168f6ff1ac9b70d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-570](https://github.com/ursa-labs/crossbow/branches/all?query=actions-570)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700002325
@github-actions crossbow submit -g wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700684118
Revision: 66a09002b2dbea7d15ed2dcef168f6ff1ac9b70d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-569](https://github.com/ursa-labs/crossbow/branches/all?query=actions-569)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#discussion_r496583885
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -24,6 +24,10 @@ set(ARROW_FLIGHT_STATIC_LINK_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF} gRPC::grpc++ c-a
if(WIN32)
list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ws2_32.lib)
+elseif(APPLE)
+ if(LIBRESOLV_LIBRARY)
+ list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ${LIBRESOLV_LIBRARY})
+ endif()
Review comment:
Updated and set libresolv as required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700610388
Revision: 66a09002b2dbea7d15ed2dcef168f6ff1ac9b70d
Submitted crossbow builds: [ursa-labs/crossbow @ actions-567](https://github.com/ursa-labs/crossbow/branches/all?query=actions-567)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700223353
Revision: 2e3d7f718eac038eabc12902ec208dab2e73008b
Submitted crossbow builds: [ursa-labs/crossbow @ actions-566](https://github.com/ursa-labs/crossbow/branches/all?query=actions-566)
|Task|Status|
|----|------|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700592390
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8289:
URL: https://github.com/apache/arrow/pull/8289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700670257
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700011652
@github-actions crossbow submit wheel-osx-cp36m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#discussion_r496451063
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -24,6 +24,10 @@ set(ARROW_FLIGHT_STATIC_LINK_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF} gRPC::grpc++ c-a
if(WIN32)
list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ws2_32.lib)
+elseif(APPLE)
+ if(LIBRESOLV_LIBRARY)
+ list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ${LIBRESOLV_LIBRARY})
+ endif()
Review comment:
Definitely :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700975583
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700031610
@github-actions crossbow submit wheel-osx-cp36m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700222102
@github-actions crossbow submit wheel-osx-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700015736
Revision: 6a8dba2f7905bba27456be70d4d22bdd0e773446
Submitted crossbow builds: [ursa-labs/crossbow @ actions-563](https://github.com/ursa-labs/crossbow/branches/all?query=actions-563)
|Task|Status|
|----|------|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700003839
https://issues.apache.org/jira/browse/ARROW-10116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700032999
Revision: 884bc5089ac4062715741bf0ddb02fbc4545dec1
Submitted crossbow builds: [ursa-labs/crossbow @ actions-565](https://github.com/ursa-labs/crossbow/branches/all?query=actions-565)
|Task|Status|
|----|------|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#discussion_r496302896
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -24,6 +24,10 @@ set(ARROW_FLIGHT_STATIC_LINK_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF} gRPC::grpc++ c-a
if(WIN32)
list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ws2_32.lib)
+elseif(APPLE)
+ if(LIBRESOLV_LIBRARY)
+ list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ${LIBRESOLV_LIBRARY})
+ endif()
Review comment:
Can we use `set_target_properties(c-ares::cares PROPERTIES INTERFACE_LINK_LIBRARIES "${LIBRESOLV_LIBRARY}")` instead of this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#issuecomment-700015736
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org