You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "sboorlagadda (GitHub)" <gi...@apache.org> on 2018/10/08 20:27:12 UTC

[GitHub] [geode] sboorlagadda opened pull request #2580: GEODE-5212: fix failing StartLocator and Server command DUnit tests

   * Added unit tests to cover different working directory cases
   * Removed acceptance tests related to working directory as they
     seem to be fragile as paths are environment specific

Signed-off-by: Kirk Lund <kl...@apache.org>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2580: GEODE-5212: fix failing StartLocator and Server command DUnit tests

Posted by "pdxrunner (GitHub)" <gi...@apache.org>.

+1 I missed that on my recent changes

[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2580: GEODE-5212: fix failing StartLocator and Server command DUnit tests

Posted by "pdxrunner (GitHub)" <gi...@apache.org>.

Although not strictly part of this refactoring, the above test, `testAddJvmOptionsForOutOfMemoryErrors` would be better placed in the `StartServerCommandTest`, as the method being tested is (now a static) in `StartServerCommand`.

[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda closed pull request #2580: GEODE-5212: fix failing StartLocator and Server command DUnit tests

Posted by "sboorlagadda (GitHub)" <gi...@apache.org>.

[ pull request closed by sboorlagadda ]

[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on pull request #2580: GEODE-5212: fix failing StartLocator and Server command DUnit tests

Posted by "sboorlagadda (GitHub)" <gi...@apache.org>.

Done!

[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org