[jira] Resolved: (THRIFT-1014) Thrift JavaScript code should use semicolon-terminated statements

["Roger Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1014.
---------------------------------

    Resolution: Fixed

committed the latest patch!

further work on testsuite with lint is on a seperate issue: THRIFT-1089

> Thrift JavaScript code should use semicolon-terminated statements
> -----------------------------------------------------------------
>
>                 Key: THRIFT-1014
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1014
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Compiler, JavaScript - Library
>            Reporter: James Hamlin
>            Assignee: Roger Meier
>            Priority: Minor
>         Attachments: THRIFT-1014_JavaScript_lint_fixes.patch, THRIFT-1014_JavaScript_lint_fixes_generates_files.patch, THRIFT-1014_JavaScrit_ant_jslint_task.patch
>
>
> It's good style to terminate all JavaScript statements with a semicolon. Thrift's JavaScript library and generated JavaScript don't use semicolons at all. Beyond the stylistic improvement, fixing up the syntax would make Thrift's JavaScript compatible with certain JavaScript linters, e.g. Google Closure's.
> I have a patch that's about ready if the project will take contributions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira