You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/30 02:30:00 UTC

[GitHub] [incubator-seatunnel] mans2singh opened a new pull request, #3232: [hotfix][connector][jdbc] Updated batch size description

mans2singh opened a new pull request, #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232

   
   ## Purpose of this pull request
   
   Clarified the batch size description.  Updated description from <code>when the number of **buffers** reaches the number of `batch_size`</code> to <code>when the number of **buffered records** reaches the number of `batch_size`</code>
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3232: [hotfix][connector][jdbc] Updated batch size description

Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232#issuecomment-1296148102

   please update pr title to [Doc][Connector-V2][jdbc] Updated batch size description 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #3232: [Doc][Connector-V2][jdbc] Updated batch size description

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] mans2singh commented on pull request #3232: [Doc][Connector-V2][jdbc] Updated batch size description

Posted by GitBox <gi...@apache.org>.
mans2singh commented on PR #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232#issuecomment-1296533393

   Thanks @CalvinKirs 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] mans2singh commented on pull request #3232: [Doc][Connector-V2][jdbc] Updated batch size description

Posted by GitBox <gi...@apache.org>.
mans2singh commented on PR #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232#issuecomment-1296241046

   @TaoZex, @Hisoka-X, @hailin0   - Thanks for your review.  I have updated the title based on your recommendations.  Please let me know if there is anything else required.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] mans2singh commented on pull request #3232: [Doc][Connector-V2][jdbc] Updated batch size description

Posted by GitBox <gi...@apache.org>.
mans2singh commented on PR #3232:
URL: https://github.com/apache/incubator-seatunnel/pull/3232#issuecomment-1296412710

   @TaoZex  - I have updated the title, please let me know if you have any more recommendations.  Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org