You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by lispking <gi...@git.apache.org> on 2015/09/14 16:05:42 UTC

[GitHub] storm pull request: Update ObjectDef.java

GitHub user lispking opened a pull request:

    https://github.com/apache/storm/pull/732

    Update ObjectDef.java

    update:let constructorArgs support map type.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lispking/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #732
    
----
commit a019d504dff6492e4b5a18387b7281a918dca0e9
Author: lispking <li...@qq.com>
Date:   2015-09-14T14:03:30Z

    Update ObjectDef.java
    
    update:let constructorArgs support map type.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Update ObjectDef.java for flux

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/732#issuecomment-159378631
  
    +1 tests can be added later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Update ObjectDef.java for flux

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/732


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Update ObjectDef.java for flux

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/732#issuecomment-154555263
  
    I'd like to see this change covered by the unit tests. It should be as simple as adding a constructor, config method, etc. that takes a map as input to one of the dummy classes, then reference it in one of the unit test YAML files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Update ObjectDef.java for flux

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/732#issuecomment-154546170
  
    @lispking is there a JIRA for this?  The change looks good to me and I am +1 for merging it in.
    
    @ptgoetz could you also take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---