Re: [PR] HIVE-28838: Remove sensitive jdbc properties from explain plan for JdbcStorageHandler tables [hive]

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2024799000


##########
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java:
##########
@@ -1230,7 +1233,12 @@ public static Class<? extends AbstractSerDe> getDefaultSerDe() {
     return LazySimpleSerDe.class;
   }
 
-  private static final String[] FILTER_OUT_FROM_EXPLAIN = {TABLE_IS_CTAS};
+  private static final String[] FILTER_OUT_FROM_EXPLAIN = {
+          TABLE_IS_CTAS,
+          JDBC_USERNAME,

Review Comment:
   @InvisibleProgrammer, what about
   ````
     public Map<String, String> getTblPropsExplain() { // only for displaying plan
       return PlanUtils.getPropertiesForExplain(tblProps,
         hive_metastoreConstants.TABLE_IS_CTAS,
         hive_metastoreConstants.TABLE_BUCKETING_VERSION);
     }
   ````
   it covers explain CTAS query



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org