[GitHub] [samza] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor
URL: https://github.com/apache/samza/pull/920#discussion_r262266804
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java
 ##########
 @@ -82,10 +84,13 @@ ExecutionPlan getExecutionPlan(String runId) {
             userConfig.get(TaskConfig.INPUT_STREAMS()));
         allowedUserConfig.remove(TaskConfig.INPUT_STREAMS());
       }
-
       generatedConfig.putAll(getGeneratedConfig(runId));
     }
 
+    // Generate job.id and job.name configs from app.id and app.name if defined
+    MapConfig generatedJobConfigs = JobConfigUtil.generateJobIdAndName(new MapConfig(allowedUserConfig));
 
 Review comment:
   will do 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services