[jira] Commented: (XERCESJ-956) Problem with getBaseSystemId() in XMLEntityScanner

[ji...@apache.org]

The following comment has been added to this issue:

     Author: nddelima
    Created: Mon, 10 May 2004 8:17 AM
       Body:
There are a couple of dependencies on getBaseSystemId(), so simply applying the suggested change without visiting these dependencies might break them.  Looking at the CVS logs for XMLEntityManager, seems like way back in Xerces2.0.0 (XMLEntityManager CVS version 1.24), a change was made to getBaseSystemId() (in the EntityScanner inner class in XMLEntityManager) to return the expanded system ID to fix some defect.  It's not apparent why this change was made here.  Seems like this code made it's way to XMLEntityScanner.
---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/XERCESJ-956?page=comments#action_35474

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/XERCESJ-956

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XERCESJ-956
    Summary: Problem with getBaseSystemId() in XMLEntityScanner
       Type: Bug

     Status: Unassigned
   Priority: Minor

    Project: Xerces2-J
 Components: 
             Other

   Assignee: 
   Reporter: nddelima

    Created: Fri, 7 May 2004 1:43 PM
    Updated: Mon, 10 May 2004 8:17 AM

Description:
The method public String getBaseSystemId() from org.apache.xerces.impl.XMLEntityScanner.java appears to return the external expanded system identifier instead of the base system identifier.

/**
 * Returns the base system identifier of the currently scanned
 * entity, or null if none is available.
 */
public String getBaseSystemId() {
    return (fCurrentEntity != null && fCurrentEntity.entityLocation != null) ? fCurrentEntity.entityLocation.getExpandedSystemId() : null;
} // getBaseSystemId():String


Suggested patch:

/**
 * Returns the base system identifier of the currently scanned
 * entity, or null if none is available.
 */
public String getBaseSystemId() {
	return (fCurrentEntity != null && fCurrentEntity.entityLocation != null) ? fCurrentEntity.entityLocation.getBaseSystemId() : null;
} // getBaseSystemId():String


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-j-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-j-dev-help@xml.apache.org