You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/03/22 01:26:42 UTC
Re: Review Request 19501: Added cache_test.cpp for to test stout Cache.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/
-----------------------------------------------------------
(Updated March 21, 2014, 5:26 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Comments.
Summary (updated)
-----------------
Added cache_test.cpp for to test stout Cache.
Bugs: MESOS-1123
https://issues.apache.org/jira/browse/MESOS-1123
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19501/diff/
Testing
-------
make check -j GTEST_FILTER=*Cache*
Thanks,
Jiang Yan Xu
Re: Review Request 19501: Added cache_test.cpp for stout Cache.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/#review38244
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19501]
All tests passed.
- Mesos ReviewBot
On March 22, 2014, 12:27 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19501/
> -----------------------------------------------------------
>
> (Updated March 22, 2014, 12:27 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1123
> https://issues.apache.org/jira/browse/MESOS-1123
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
> 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19501/diff/
>
>
> Testing
> -------
>
> make check -j GTEST_FILTER=*Cache*
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 19501: Added cache_test.cpp for stout Cache.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/#review38348
-----------------------------------------------------------
Looks great! Just some small cleanup below.
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
<https://reviews.apache.org/r/19501/#comment70431>
Can you add the missing include for <string> and use it explicitly, rather than use the entire std:: namespace?
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
<https://reviews.apache.org/r/19501/#comment70433>
Should you do a get of '4' here to ensure it's still present? In this line you're making 2 the MRU item, which we only want to do in the put on line 64, right?
- Ben Mahler
On March 22, 2014, 12:27 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19501/
> -----------------------------------------------------------
>
> (Updated March 22, 2014, 12:27 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1123
> https://issues.apache.org/jira/browse/MESOS-1123
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
> 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19501/diff/
>
>
> Testing
> -------
>
> make check -j GTEST_FILTER=*Cache*
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 19501: Added cache_test.cpp for to test stout Cache.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/#review38488
-----------------------------------------------------------
Ship it!
Looks good! I have a small comment below but I will fix it for you when I commit.
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp
<https://reviews.apache.org/r/19501/#comment70693>
This goes above the other includes.
- Ben Mahler
On March 25, 2014, 5:39 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19501/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 5:39 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1123
> https://issues.apache.org/jira/browse/MESOS-1123
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
> 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19501/diff/
>
>
> Testing
> -------
>
> make check -j GTEST_FILTER=*Cache*
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 19501: Added cache_test.cpp for to test stout Cache.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/
-----------------------------------------------------------
(Updated March 25, 2014, 10:39 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Cleanup. NNFR.
Summary (updated)
-----------------
Added cache_test.cpp for to test stout Cache.
Bugs: MESOS-1123
https://issues.apache.org/jira/browse/MESOS-1123
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19501/diff/
Testing
-------
make check -j GTEST_FILTER=*Cache*
Thanks,
Jiang Yan Xu
Re: Review Request 19501: Added cache_test.cpp for stout Cache.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/
-----------------------------------------------------------
(Updated March 21, 2014, 5:27 p.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
Added cache_test.cpp for stout Cache.
Bugs: MESOS-1123
https://issues.apache.org/jira/browse/MESOS-1123
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 84931554341376229386a3a853470ee7c4f89c5f
3rdparty/libprocess/3rdparty/stout/Makefile.am df149ddc8669b0c541361922631f4f3958bd096d
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 67b88bc5959e2d8c2cee5c0a218229c293afcf60
3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19501/diff/
Testing
-------
make check -j GTEST_FILTER=*Cache*
Thanks,
Jiang Yan Xu