mailing list vs git/jira issues

[Jon Malkin <jm...@apache.org>]

I'm working on a C++ sketch and trying to make sure I'm handling memory
properly. In the debugging process, I noticed that serde.hpp uses placement
new in deserialize(), without allowing for a custom allocator (which it
seems needs to implement construct(), not just allocate().)

This is a very specific question related to the C++ implementation; I'd
usually not think of sending it out to the entire dev@ list, favoring a
discussion more localized to the specific repo. But maybe, at least while
trying to build a community and promote activity on the list, it's worth
trying to have such conversations on the list?

  jon

Re: mailing list vs git/jira issues

[Evans Ye <ev...@apache.org>]

Usually I see the pattern is to encourage the discussion in mailing list.
As you said that shows how active the community is for both existing
community members as well as external potential contributors. Once the
mailing list is growing to an unmanageable phase, the community starts to
discuss about splitting by component(hadoop to hdfs, yarn), language(flink
adds user-zh), message types(separate PRs, JIRAs to dedicate lists).

Same idea goes to JIRA, usually at ASF most of the projects use JIRA for
issue tracking. It's a centralized place for people to see what currently
community is paving towards; how many issues/features are opened/closed;
and most importantly, what issue I can help on and become a contributor.

Evans

Jon Malkin <jo...@gmail.com> 於 2020年1月18日 週六 上午4:46寫道：

> Correct, it does not allocate. The use of the generic placement new,
> however, means there's no way to use a custom allocator's implementation of
> construct() or destroy() in a serde.
>
>   jon
>
> On Fri, Jan 17, 2020 at 10:41 AM Alexander Saydakov
> <sa...@verizonmedia.com.invalid> wrote:
>
>> Serde does not allocate. Where do you see allocation? Placement new is a
>> way to call a constructor without allocation.
>>
>> On Thu, Jan 16, 2020 at 8:52 PM Kenneth Knowles <ke...@apache.org> wrote:
>>
>>> As mentor, I have a couple thoughts:
>>>
>>>  - You are probably right that including dev@ is helpful for building
>>> community
>>>  - Datasketches dev@ list is tiny and you should definitely send to it
>>> without hesitation IMO
>>>  - If it is too detailed for the dev list, that is probably harmless
>>> anyhow - I have seen this level of discussion, for sure.
>>>  - Try browsing other Apache projects dev lists to see how they do it;
>>> example:
>>> https://lists.apache.org/list.html?dev@avro.apache.org:lte=1y:-%5Bjira%5D
>>>
>>> I have no helpful thoughts on your C++ question :-)
>>>
>>> Kenn
>>>
>>> On Thu, Jan 16, 2020 at 8:36 PM Jon Malkin <jm...@apache.org> wrote:
>>>
>>>> I'm working on a C++ sketch and trying to make sure I'm handling memory
>>>> properly. In the debugging process, I noticed that serde.hpp uses placement
>>>> new in deserialize(), without allowing for a custom allocator (which it
>>>> seems needs to implement construct(), not just allocate().)
>>>>
>>>> This is a very specific question related to the C++ implementation; I'd
>>>> usually not think of sending it out to the entire dev@ list, favoring
>>>> a discussion more localized to the specific repo. But maybe, at least while
>>>> trying to build a community and promote activity on the list, it's worth
>>>> trying to have such conversations on the list?
>>>>
>>>>   jon
>>>>
>>>

Re: mailing list vs git/jira issues

[Jon Malkin <jo...@gmail.com>]

Correct, it does not allocate. The use of the generic placement new,
however, means there's no way to use a custom allocator's implementation of
construct() or destroy() in a serde.

  jon

On Fri, Jan 17, 2020 at 10:41 AM Alexander Saydakov
<sa...@verizonmedia.com.invalid> wrote:

> Serde does not allocate. Where do you see allocation? Placement new is a
> way to call a constructor without allocation.
>
> On Thu, Jan 16, 2020 at 8:52 PM Kenneth Knowles <ke...@apache.org> wrote:
>
>> As mentor, I have a couple thoughts:
>>
>>  - You are probably right that including dev@ is helpful for building
>> community
>>  - Datasketches dev@ list is tiny and you should definitely send to it
>> without hesitation IMO
>>  - If it is too detailed for the dev list, that is probably harmless
>> anyhow - I have seen this level of discussion, for sure.
>>  - Try browsing other Apache projects dev lists to see how they do it;
>> example:
>> https://lists.apache.org/list.html?dev@avro.apache.org:lte=1y:-%5Bjira%5D
>>
>> I have no helpful thoughts on your C++ question :-)
>>
>> Kenn
>>
>> On Thu, Jan 16, 2020 at 8:36 PM Jon Malkin <jm...@apache.org> wrote:
>>
>>> I'm working on a C++ sketch and trying to make sure I'm handling memory
>>> properly. In the debugging process, I noticed that serde.hpp uses placement
>>> new in deserialize(), without allowing for a custom allocator (which it
>>> seems needs to implement construct(), not just allocate().)
>>>
>>> This is a very specific question related to the C++ implementation; I'd
>>> usually not think of sending it out to the entire dev@ list, favoring a
>>> discussion more localized to the specific repo. But maybe, at least while
>>> trying to build a community and promote activity on the list, it's worth
>>> trying to have such conversations on the list?
>>>
>>>   jon
>>>
>>

Re: mailing list vs git/jira issues

[Alexander Saydakov <sa...@verizonmedia.com.INVALID>]

Serde does not allocate. Where do you see allocation? Placement new is a
way to call a constructor without allocation.

On Thu, Jan 16, 2020 at 8:52 PM Kenneth Knowles <ke...@apache.org> wrote:

> As mentor, I have a couple thoughts:
>
>  - You are probably right that including dev@ is helpful for building
> community
>  - Datasketches dev@ list is tiny and you should definitely send to it
> without hesitation IMO
>  - If it is too detailed for the dev list, that is probably harmless
> anyhow - I have seen this level of discussion, for sure.
>  - Try browsing other Apache projects dev lists to see how they do it;
> example:
> https://lists.apache.org/list.html?dev@avro.apache.org:lte=1y:-%5Bjira%5D
>
> I have no helpful thoughts on your C++ question :-)
>
> Kenn
>
> On Thu, Jan 16, 2020 at 8:36 PM Jon Malkin <jm...@apache.org> wrote:
>
>> I'm working on a C++ sketch and trying to make sure I'm handling memory
>> properly. In the debugging process, I noticed that serde.hpp uses placement
>> new in deserialize(), without allowing for a custom allocator (which it
>> seems needs to implement construct(), not just allocate().)
>>
>> This is a very specific question related to the C++ implementation; I'd
>> usually not think of sending it out to the entire dev@ list, favoring a
>> discussion more localized to the specific repo. But maybe, at least while
>> trying to build a community and promote activity on the list, it's worth
>> trying to have such conversations on the list?
>>
>>   jon
>>
>

Re: mailing list vs git/jira issues

[Kenneth Knowles <ke...@apache.org>]

As mentor, I have a couple thoughts:

 - You are probably right that including dev@ is helpful for building
community
 - Datasketches dev@ list is tiny and you should definitely send to it
without hesitation IMO
 - If it is too detailed for the dev list, that is probably harmless anyhow
- I have seen this level of discussion, for sure.
 - Try browsing other Apache projects dev lists to see how they do it;
example:
https://lists.apache.org/list.html?dev@avro.apache.org:lte=1y:-%5Bjira%5D

I have no helpful thoughts on your C++ question :-)

Kenn

On Thu, Jan 16, 2020 at 8:36 PM Jon Malkin <jm...@apache.org> wrote:

> I'm working on a C++ sketch and trying to make sure I'm handling memory
> properly. In the debugging process, I noticed that serde.hpp uses placement
> new in deserialize(), without allowing for a custom allocator (which it
> seems needs to implement construct(), not just allocate().)
>
> This is a very specific question related to the C++ implementation; I'd
> usually not think of sending it out to the entire dev@ list, favoring a
> discussion more localized to the specific repo. But maybe, at least while
> trying to build a community and promote activity on the list, it's worth
> trying to have such conversations on the list?
>
>   jon
>