You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2016/09/01 08:02:22 UTC
[GitHub] storm pull request #1667: STORM-2076: Add new atom to prevent sync-processes...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1667
STORM-2076: Add new atom to prevent sync-processes from deleting new \u2026
\u2026topology code
@HeartSaVioR Could you take a look at this? I'll make a similar change on master if you think this is the right solution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2076
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1667.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1667
----
commit 57b10b258c2ebe969ed025a0852fda68e3621ba4
Author: Stig Rohde D�ssing <sd...@it-minds.dk>
Date: 2016-08-30T08:28:41Z
STORM-2076: Add new atom to prevent sync-processes from deleting new topology code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1667: STORM-2076: Add new atom to prevent sync-processes from d...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1667
Hi @srdo,
Great catch and thanks for the contribution.
Btw, as we're continuously suffering race conditions in supervisor, @revans2 proposed new supervisor design and submitted pull request - [STORM-2018](issues.apache.org/jira/browse/STORM-2018) #1642
I'm not sure when we can finish reviewing and deciding to merge, but review comments are positive so I guess we can switch supervisor to V2 in near future. For now #1642 is for master, but since we found race even 1.0.2 again, I think we should port back to 1.x and 1.0.x and release.
Could you help to review #1642 if you don't mind? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1667: STORM-2076: Add new atom to prevent sync-processes from d...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1667
Closing this since SupervisorV2 was merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1667: STORM-2076: Add new atom to prevent sync-processes...
Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:
https://github.com/apache/storm/pull/1667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1667: STORM-2076: Add new atom to prevent sync-processes from d...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1667
@HeartSaVioR Sure, the new design looks much nicer. I agree that backporting the new design if it works well makes more sense than to keep patching these race conditions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---