[GitHub] [orc] stiga-huang commented on a diff in pull request #1100: ORC-1160: [C++] Fix seekToRow can't seek within selected row group

[GitBox <gi...@apache.org>]

stiga-huang commented on code in PR #1100:
URL: https://github.com/apache/orc/pull/1100#discussion_r860366677


##########
c++/test/TestPredicatePushdown.cc:
##########
@@ -237,6 +269,15 @@ namespace orc {
     TestRangePredicates(reader.get());
     TestNoRowsSelected(reader.get());
     TestOrPredicates(reader.get());
+
+    TestSeekWithPredicates(reader.get(), 0);
+    TestSeekWithPredicates(reader.get(), 10);
+    TestSeekWithPredicates(reader.get(), 100);
+    TestSeekWithPredicates(reader.get(), 500);
+    TestSeekWithPredicates(reader.get(), 999);
+    TestSeekWithPredicates(reader.get(), 1000);
+    TestSeekWithPredicates(reader.get(), 1001);
+    TestSeekWithPredicates(reader.get(), 4000);

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org