[jira] [Commented] (KARAF-6074) Race condition between the FeaturesService and FeatureDeploymentListener

["Grzegorz Grzybek (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965585#comment-16965585 ] 

Grzegorz Grzybek commented on KARAF-6074:
-----------------------------------------

IMO, {{mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.features/4.2.4 = 26}} should simply not be part of startup properties... Features service (which _switches_ from {{etc/startup.properties}} to more sophisticated {{etc/org.apache.karaf.features.cfg}}, or in other words simply from Felix to Karaf) should be used for such scenarios.
Especially because you're trying to install a bundle that's supposed to install features - it should be installed as feature, not as bundle ;)
[~jbonofre] wdyt?

> Race condition between the FeaturesService and FeatureDeploymentListener
> ------------------------------------------------------------------------
>
>                 Key: KARAF-6074
>                 URL: https://issues.apache.org/jira/browse/KARAF-6074
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 4.2.2, 4.2.4
>         Environment: Karaf 4.2.2 Windows 7 and Equinox
>            Reporter: J. Brébec
>            Assignee: Grzegorz Grzybek
>            Priority: Critical
>             Fix For: 4.2.3
>
>
> On the first start of a custom Karaf container (4.2.2), the logs shows a log of NPE in FeatureDeploymentListener.
> After some analysis of this Exception, it's look like a race condition between the FeaturesService and the FeatureDeploymentListener :
>  # The FeaturesService starts and launch a provisioning in another thread
>  # a FeatureDeploymentListener is registered, and call bundleChanged for every bundle installed (the startup bundles)
>  # It calls FeaturesService.state.requirements and get an empty map
>  # Updating the root regions in the requirements map fails with an NPE
>  # Some times later, the deployment task launched at step 1 is started, and FeaturesService.saveState() is called : state.requirements."root region" is initialised
> The step 5 is executed in another thread, so it can happens before step 2 (and it works) or after, causing this NPE
> Moreover, some methods in FeaturesService assume that state.requirements."root region" exists. There are probably others npe here.
>  
> {code:java}
> 14:37:55.668 ERROR [activator-1-thread-2] Unable to update deployed features for bundle: org.eclipse.osgi - 3.12.100.v20180210-1608
> java.lang.NullPointerException: null
> at org.apache.karaf.deployer.features.FeatureDeploymentListener.bundleChanged(FeatureDeploymentListener.java:247) [25:org.apache.karaf.deployer.features:4.2.2]
> at org.apache.karaf.deployer.features.FeatureDeploymentListener.init(FeatureDeploymentListener.java:95) [25:org.apache.karaf.deployer.features:4.2.2]
> at org.apache.karaf.deployer.features.osgi.Activator.doStart(Activator.java:52) [25:org.apache.karaf.deployer.features:4.2.2]
> at org.apache.karaf.util.tracker.BaseActivator.run(BaseActivator.java:292) [25:org.apache.karaf.deployer.features:4.2.2]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)