You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2023/04/20 15:04:13 UTC

[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6056: Update DataFusion architecture documentation

comphead commented on code in PR #6056:
URL: https://github.com/apache/arrow-datafusion/pull/6056#discussion_r1172720822


##########
datafusion/core/src/datasource/empty.rs:
##########
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//! An empty plan that is usefull for testing and generating plans without mapping them to actual data.
+//! [`EmptyTable`] usefull for testing.

Review Comment:
   ```suggestion
   //! [`EmptyTable`] useful for testing.
   ```



##########
datafusion/core/src/datasource/empty.rs:
##########
@@ -30,7 +30,8 @@ use crate::logical_expr::Expr;
 use crate::physical_plan::project_schema;
 use crate::physical_plan::{empty::EmptyExec, ExecutionPlan};
 
-/// A table with a schema but no data.
+/// An empty plan that is usefull for testing and generating plans

Review Comment:
   ```suggestion
   /// An empty plan that is useful for testing and generating plans
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org