You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/04/23 01:13:22 UTC
Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Repository: mesos-git
Description
-------
The new fixture will be used in registar zk tests in a subsequent review.
Diffs
-----
src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
Diff: https://reviews.apache.org/r/20584/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 22, 2014, 11:26 p.m., Jiang Yan Xu wrote:
> > src/tests/mesos.cpp, lines 28-31
> > <https://reviews.apache.org/r/20584/diff/1/?file=564981#file564981line28>
> >
> > Do these belong to this review?
Yes. This is the initialization of static variables of MesosZooKeeperTest.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/#review41085
-----------------------------------------------------------
On April 23, 2014, 7:34 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20584/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:34 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The new fixture will be used in registar zk tests in a subsequent review.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
> src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
> src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
>
> Diff: https://reviews.apache.org/r/20584/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/#review41085
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/20584/#comment74491>
These can be moved now that MasterZooKeeperTest is renamed and moved.
src/tests/mesos.cpp
<https://reviews.apache.org/r/20584/#comment74488>
Do these belong to this review?
- Jiang Yan Xu
On April 22, 2014, 4:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20584/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 4:13 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The new fixture will be used in registar zk tests in a subsequent review.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
> src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
> src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
>
> Diff: https://reviews.apache.org/r/20584/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/
-----------------------------------------------------------
(Updated April 23, 2014, 9:57 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
yan's. NNFR.
Repository: mesos-git
Description
-------
The new fixture will be used in registar zk tests in a subsequent review.
Diffs (updated)
-----
src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
Diff: https://reviews.apache.org/r/20584/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/#review41171
-----------------------------------------------------------
Ship it!
src/tests/mesos.cpp
<https://reviews.apache.org/r/20584/#comment74576>
Should they be enclosed by #ifdef MESOS_HAS_JAVA?
- Jiang Yan Xu
On April 23, 2014, 12:34 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20584/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 12:34 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The new fixture will be used in registar zk tests in a subsequent review.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
> src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
> src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
>
> Diff: https://reviews.apache.org/r/20584/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20584: Renamed and moved MasterZooKeeperTest fixture.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20584/
-----------------------------------------------------------
(Updated April 23, 2014, 7:34 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
yan's comments.
Also fixed allocator_zookeeper tests to use the new fixture.
Repository: mesos-git
Description
-------
The new fixture will be used in registar zk tests in a subsequent review.
Diffs (updated)
-----
src/tests/allocator_zookeeper_tests.cpp 9ad0fa7c9ac970bf3a68d28a3ce756fc2b38c9c4
src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
src/tests/mesos.hpp 7bc5e981a468b81f0460e2736c8d0b76518302de
src/tests/mesos.cpp a9844e4cfef2eecbb30ca4bf1fa59d62edf93569
Diff: https://reviews.apache.org/r/20584/diff/
Testing
-------
make check
Thanks,
Vinod Kone