You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/04 15:01:24 UTC

[GitHub] [hadoop] mukund-thakur commented on pull request #2646: HADOOP-17038 Support disabling buffered reads in ABFS positional reads.

mukund-thakur commented on pull request #2646:
URL: https://github.com/apache/hadoop/pull/2646#issuecomment-773373855


   Production code looks good. Added some comments in tests.
   Also pending checkstyle 
   `./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPread.java:43:    int dataSize = 100;:20: '100' is a magic number. [MagicNumber]
   ./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPread.java:44:    byte[] data = ContractTestUtils.dataset(dataSize, 'a', 26);:60: '26' is a magic number. [MagicNumber]`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org