[GitHub] [logging-log4j2] ronosaurus opened a new pull request #736: LOG4J2-3332: SmtpAppender - option for sending buffered messages as an email attachment (text, zip, gzip)

[GitBox <gi...@apache.org>]

ronosaurus opened a new pull request #736:
URL: https://github.com/apache/logging-log4j2/pull/736


   DO NOT MERGE: candidate for a 2.19 release after more important changes occur in 2.18
   
   ```
   // logEvents.html.zip
   smtpBuilder.setAttachEvents(true);
   smtpBuilder.setAttachEventsCompression(SmtpManager.AttachEventsCompression.ZIP);
   ```
   
   ```
   // logEvents.html
   smtpBuilder.setAttachEvents(true);
   ```
   
   ```
   // logEvents.txt.gz
   smtpBuilder.setLayout(PatternLayout.createDefaultLayout())
   smtpBuilder.setAttachEvents(true);
   smtpBuilder.setAttachEventsCompression(SmtpManager.AttachEventsCompression.GZ);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] jvz commented on a change in pull request #736: LOG4J2-3332: SmtpAppender - option for sending buffered messages as an email attachment (text, zip, gzip)

[GitBox <gi...@apache.org>]

jvz commented on a change in pull request #736:
URL: https://github.com/apache/logging-log4j2/pull/736#discussion_r795089083



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##########
@@ -16,24 +16,16 @@
  */
 package org.apache.logging.log4j.core.net;
 
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
-import java.io.OutputStream;
-import java.util.Date;
-import java.util.Properties;
+import java.io.*;

Review comment:
       You'll want to change your formatter import settings to not collapse them to `*` except for static imports.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org