You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Christophe JAILLET <ch...@wanadoo.fr> on 2017/04/05 05:55:10 UTC
Re: svn commit: r1790170 - /httpd/httpd/branches/2.4.x/STATUS
Hi,
in 'remoteip_disable_networks', 'RemoteIPProxyProtocolDisableNetworks'
should be updated to 'RemoteIPProxyProtocolExceptions' or cmd->cmd->name
should used insteead.
Fonction name (i.e. 'remoteip_disable_networks') could also be updated
to better match de directive name.
(sorry, I can't fix it myself, because of issues with my WMs :( )
CJ
Le 05/04/2017 � 03:16, druggeri@apache.org a �crit :
> Author: druggeri
> Date: Wed Apr 5 01:16:26 2017
> New Revision: 1790170
>
> URL: http://svn.apache.org/viewvc?rev=1790170&view=rev
> Log:
> Update proposal with the latest trunk commit
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1790170&r1=1790169&r2=1790170&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Wed Apr 5 01:16:26 2017
> @@ -168,6 +168,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> http://svn.apache.org/r1781701 (rework optional processing case)
> http://svn.apache.org/r1788674 (final edge cases/ignore slave conns)
> http://svn.apache.org/r1789800 (remove optional processing)
> + http://svn.apache.org/r1790169 (rename "exception" directive)
> 2.4 convenience patch (includes CHANGES):
> http://people.apache.org/~druggeri/patches/RemoteIPProxyProtocol.2.4.x.patch
> +1: druggeri, jim
>
>
>
Re: svn commit: r1790170 - /httpd/httpd/branches/2.4.x/STATUS
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Mon, Apr 10, 2017 at 6:31 PM, Daniel Ruggeri <DR...@primary.net> wrote:
>
> @wrowe - I think the updated proposal addresses the concerns around the
> optional processing. Would love if you can spare a few cycles before the
> upcoming 2.4.26 to review and offer your +1 or at least nyx the -.5 note
> in case that's deterring others.
Didn't want to hold up the train, I haven't had a chance to review but the
most problematic issues are all addressed. Since I haven't reviewed, I'm
not sure whether we are now taking the easy way out with unconditional
direct bucket read line of the data, or still in an overly complicated filter
injection, but that can all be treated as code simplification at another time.
STATUS updated.
Re: svn commit: r1790170 - /httpd/httpd/branches/2.4.x/STATUS
Posted by Daniel Ruggeri <DR...@primary.net>.
On 4/5/2017 12:55 AM, Christophe JAILLET wrote:
> Hi,
>
> in 'remoteip_disable_networks', 'RemoteIPProxyProtocolDisableNetworks'
> should be updated to 'RemoteIPProxyProtocolExceptions' or
> cmd->cmd->name should used insteead.
> Fonction name (i.e. 'remoteip_disable_networks') could also be updated
> to better match de directive name.
>
> (sorry, I can't fix it myself, because of issues with my WMs :( )
>
> CJ
>
> Le 05/04/2017 � 03:16, druggeri@apache.org a �crit :
>> Author: druggeri
>> Date: Wed Apr 5 01:16:26 2017
>> New Revision: 1790170
>>
>> URL: http://svn.apache.org/viewvc?rev=1790170&view=rev
>> Log:
>> Update proposal with the latest trunk commit
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1790170&r1=1790169&r2=1790170&view=diff
>> ==============================================================================
>>
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Wed Apr 5 01:16:26 2017
>> @@ -168,6 +168,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>> http://svn.apache.org/r1781701 (rework optional
>> processing case)
>> http://svn.apache.org/r1788674 (final edge
>> cases/ignore slave conns)
>> http://svn.apache.org/r1789800 (remove optional
>> processing)
>> + http://svn.apache.org/r1790169 (rename "exception"
>> directive)
>> 2.4 convenience patch (includes CHANGES):
>>
>> http://people.apache.org/~druggeri/patches/RemoteIPProxyProtocol.2.4.x.patch
>> +1: druggeri, jim
>>
>>
>>
>
You are correct - not sure how that escaped the
s/RemoteIPProxyProtocolDisableNetworks/RemoteIPProxyProtocolExceptions/g
operation. Thanks!
I've updated the backport proposal to include your note as well as the
2.4 convenience patch.
@wrowe - I think the updated proposal addresses the concerns around the
optional processing. Would love if you can spare a few cycles before the
upcoming 2.4.26 to review and offer your +1 or at least nyx the -.5 note
in case that's deterring others.
--
Daniel Ruggeri