You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/09/17 04:30:18 UTC

[GitHub] [incubator-streampark] 1996fanrui opened a new issue, #1629: [Proposal] Support team feature

1996fanrui opened a new issue, #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/streamxhub/streampark/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues.
   
   
   ### Describe the proposal
   
   ### Background: 
   
   Currently, StreamPark doesn't support team, so all projects and applications will be showed in the same pages. For some companies, there are too many departments or teams. For ease of use and security, they shouldn't view the applicaton list of other teams.
   
   ### Solution
   
   Support the team feature, the team as the workspace in the WebUI. The front end only shows a list of projects and apps for the current team. And the apps and projects are created by default also belong to the current team.
   
   <img width="1791" alt="image" src="https://user-images.githubusercontent.com/38427477/190838813-06d0be1e-df5c-4e86-86e3-805d2ca27274.png">
   
   <img width="1789" alt="image" src="https://user-images.githubusercontent.com/38427477/190839010-db20b9d2-0741-4421-bb5e-59057c4c2e37.png">
   
   ### Team management
   
   Create/Modify/Delete/View team information.
   
   <img width="1791" alt="image" src="https://user-images.githubusercontent.com/38427477/190840405-b691d8e7-dde7-4641-bb70-618ba73b9e0d.png">
   
   
   
   ### Member management
   
   Add a Member management page, and create a default team.
   
   Member management page feature:
   
   - Which members of the current team?
   - What is the role of the members in the current team?
   
   
   ![image](https://user-images.githubusercontent.com/38427477/190840304-8b99b1e5-4cd2-4307-ab49-f62cbc5307c5.png)
   
   
   <img width="1791" alt="image" src="https://user-images.githubusercontent.com/38427477/190840114-77f86e59-70b1-4690-a480-7b7563067a3a.png">
   
   ### Role management 
   
   We just set whether new user is system admin during creating a new user. The other roles will be management in the team management page.
   
   > Note: System admin is the super admin for all teams.
   
   <img width="680" alt="image" src="https://user-images.githubusercontent.com/38427477/190840186-6309d818-fe86-47e2-8092-fb243bae7731.png">
   
   
   ### Compatibility mechanism:
   
   - Add a new role, that is team admin. It will be the super admin inside team(manage team member, operate all apps and projects).
   - All old apps and projects will be migrated to the default team.
   - All developer will be granted to the default team developer.
   
   
   ### Task list
   
   Will fill this in later.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] 1996fanrui commented on issue #1629: [Proposal] Support team feature

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-1250035847

   > It looks good, The team here is actually the concept of workspace. There are a few issues that need to be clarified
   
   @wolfboys , thank you for reviewing the solution. I have updated the doc for these questions. 
   
   > 1. one project or job only belong to one team?
   
   - Each project can only belong to one team.
   - Each app can only belong to one team.
   
   
   > 2. What is the affiliation between users and teams, one to one?
   
   - Each user can belong to multiple teams
   - Each team can have multiple users
   - Each user can have different roles in different teams, for example: userA is team_admin in team1, userA is developer in team2
   
   > 3. Do we need an association table between team and user (team and job)?
   
   Add the team_id to these tables:
   - `t_flink_app`
   - `t_flink_project`
   - `t_user_role`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Proposal] Support team feature [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-2229630440

   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] 1996fanrui commented on issue #1629: [Proposal] Support team feature

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-1249998547

   Hi @wolfboys , I have sorted out the team feature. Please help take a look in your free time, thanks a lot.
   
   If it's ok, I will start develop the backend code, and try to develop front end. I will let you know, if I need your help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on issue #1629: [Proposal] Support team feature

Posted by GitBox <gi...@apache.org>.
wolfboys commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-1250031447

   It looks good, The team here is actually the concept of workspace.  There are a few issues that need to be clarified
   1) one project or job only belong to one team?
   2) What is the affiliation between users and teams, one to one?
   3) Do we need an association table between team and user (team and job)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on issue #1629: [Proposal] Support team feature

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-1250013971

   Hi @1996fanrui, Thanks for you feedback! This is a nice proposal.  
   Could you offer the ER model about the team feature to describe their relation in more detail?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] 1996fanrui commented on issue #1629: [Proposal] Support team feature

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on issue #1629:
URL: https://github.com/apache/incubator-streampark/issues/1629#issuecomment-1250026493

   Hi @lvshaokang , thanks for your nice suggestion, I have updated the ER model, PTAL in your free time, thanks a lot~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Proposal] Support team feature [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys closed issue #1629: [Proposal] Support team feature
URL: https://github.com/apache/incubator-streampark/issues/1629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org