You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wzhfy <gi...@git.apache.org> on 2017/09/13 01:39:47 UTC
[GitHub] spark pull request #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19213
[SPARK-17642] [SQL] [FOLLOWUP] improve comments
## What changes were proposed in this pull request?
Improve comments for some RunnableCommands for table.
## How was this patch tested?
Only comments. Not related to tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wzhfy/spark useless_comment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19213
----
commit 0afc9f704100b7dda94de7eb50569248a9444b55
Author: Zhenhua Wang <wa...@huawei.com>
Date: 2017-09-13T01:25:52Z
improve comments
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81747/testReport)** for PR 19213 at commit [`d922c85`](https://github.com/apache/spark/commit/d922c85fe6e462df122450ed015c0a7e722d2e2c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19213
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81698/testReport)** for PR 19213 at commit [`0afc9f7`](https://github.com/apache/spark/commit/0afc9f704100b7dda94de7eb50569248a9444b55).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables a...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19213#discussion_r138817857
--- Diff: sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -13,6 +13,8 @@ DESC FORMATTED desc_col_temp_table desc_col_temp_table.key;
-- Describe a non-existent column
DESC desc_col_temp_table key1;
+DROP VIEW desc_col_temp_table;
--- End diff --
since it's a view, can we name it `desc_col_temp_view`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81698/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19213
thanks, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19213
LGTM, please also address one more comment that drop testing tables.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81698/testReport)** for PR 19213 at commit [`0afc9f7`](https://github.com/apache/spark/commit/0afc9f704100b7dda94de7eb50569248a9444b55).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81774/testReport)** for PR 19213 at commit [`a995edc`](https://github.com/apache/spark/commit/a995edc26d9e4d6803973095b3092a5ca50639d6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81747/testReport)** for PR 19213 at commit [`d922c85`](https://github.com/apache/spark/commit/d922c85fe6e462df122450ed015c0a7e722d2e2c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19213
**[Test build #81774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81774/testReport)** for PR 19213 at commit [`a995edc`](https://github.com/apache/spark/commit/a995edc26d9e4d6803973095b3092a5ca50639d6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables a...
Posted by wzhfy <gi...@git.apache.org>.
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19213#discussion_r138820941
--- Diff: sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -13,6 +13,8 @@ DESC FORMATTED desc_col_temp_table desc_col_temp_table.key;
-- Describe a non-existent column
DESC desc_col_temp_table key1;
+DROP VIEW desc_col_temp_table;
--- End diff --
ok. I'll fix it right now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81747/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by wzhfy <gi...@git.apache.org>.
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19213
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81774/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables and impr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19213: [SPARK-17642] [SQL] [FOLLOWUP] drop test tables a...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19213#discussion_r138818475
--- Diff: sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -13,6 +13,8 @@ DESC FORMATTED desc_col_temp_table desc_col_temp_table.key;
-- Describe a non-existent column
DESC desc_col_temp_table key1;
+DROP VIEW desc_col_temp_table;
--- End diff --
and it's better to put all `DROP` commands at the end.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19213: [SPARK-17642] [SQL] [FOLLOWUP] improve comments
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19213
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org