You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/02 07:00:45 UTC
[GitHub] [incubator-doris] zuochunwei opened a new pull request #8292: (improving) refactor column::insert_many_dict_data
zuochunwei opened a new pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292
# Proposed changes
i have tested this changes by adding global atomic timer: clock_gettime(CLOCK_MONOTONIC, &ts);
before vs after modifying, test sql ssb Q2.1
SELECT sum(lo_revenue), year(lo_orderdate) AS year, p_brand
FROM lineorder_flat
WHERE p_category = 'MFGR#12' AND s_region = 'AMERICA'
GROUP BY year, p_brand
ORDER BY year, p_brand;
result:
PredicateColumnType::insert_many_dict_data() 11970424864 vs 8907241614
ColumnString::insert_many_dict_data 3044568165 vs 2467506128
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] spaces-X commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
spaces-X commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817407427
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -32,6 +32,8 @@
#include "vec/common/sip_hash.h"
#include "vec/core/field.h"
+#include "../../util/mem_util.hpp"
Review comment:
Maybe it's better to use an absolute path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818284576
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -32,6 +32,8 @@
#include "vec/common/sip_hash.h"
#include "vec/core/field.h"
+#include "../../util/mem_util.hpp"
Review comment:
`#include "util/mem_util.hpp"` also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593797
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
Review comment:
clocks计数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r821442814
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -32,6 +32,8 @@
#include "vec/common/sip_hash.h"
#include "vec/core/field.h"
+#include "../../util/mem_util.hpp"
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo removed a comment on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo removed a comment on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1062506688
I feel that this pr will improve performance when reading string column without conditions, because this pr removed branch judgment when writing data to ColumString's offsets;
We can see no performance improvement for query 2.1 because the amount of data written to Columnstring after predicate pruning is already very small.
I will test for this case later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1056449402
Please add ```BlockLoadTime``` Timer for performance improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818267646
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -32,6 +32,8 @@
#include "vec/common/sip_hash.h"
#include "vec/core/field.h"
+#include "../../util/mem_util.hpp"
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818268350
##########
File path: be/src/vec/columns/column.h
##########
@@ -174,7 +174,7 @@ class IColumn : public COW<IColumn> {
LOG(FATAL) << "Method insert_many_fix_len_data is not supported for " << get_name();
}
- virtual void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) {
+ virtual void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) {
Review comment:
I think here `__restrict` is useless, because function is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo edited a comment on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo edited a comment on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1056449402
Please add ```BlockLoadTime``` Timer for performance improvement.
I don't know what does ```11970424864 vs 8907241614``` means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1062506689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593579
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
Review comment:
> Please add `BlockLoadTime` Timer for performance improvement. I don't know what does `11970424864 vs 8907241614` means.
我用一个atomic_uint64的全局变量，累加了这个函数的开销
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817516579
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
Review comment:
better to use auto for codeword:
```
auto codeword = data_array[index];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r818268350
##########
File path: be/src/vec/columns/column.h
##########
@@ -174,7 +174,7 @@ class IColumn : public COW<IColumn> {
LOG(FATAL) << "Method insert_many_fix_len_data is not supported for " << get_name();
}
- virtual void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) {
+ virtual void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) {
Review comment:
I think here `__restrict` is useless, because function is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817593579
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
Review comment:
> Please add `BlockLoadTime` Timer for performance improvement. I don't know what does `11970424864 vs 8907241614` means.
我用一个atomic_uint64的全局变量，累加了这个函数的开销
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
Review comment:
clocks计数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] levy5307 commented on a change in pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#discussion_r817516069
##########
File path: be/src/vec/columns/column_string.h
##########
@@ -165,10 +167,33 @@ class ColumnString final : public COWHelper<IColumn, ColumnString> {
}
};
- void insert_many_dict_data(const int32_t* data_array, size_t start_index, const StringRef* dict, size_t num) override {
- for (size_t end_index = start_index+num; start_index < end_index; ++start_index) {
- int32_t codeword = data_array[start_index];
- insert_data(dict[codeword].data, dict[codeword].size);
+ void insert_many_dict_data(const int32_t* __restrict data_array, size_t start_index, const StringRef* __restrict dict, size_t num) override {
+ size_t index = start_index;
+ const size_t end = start_index + num;
+
+ // handle offsets
+ size_t old_size = offsets.size();
+ offsets.resize(old_size + num);
+
+ size_t chars_old_size = chars.size();
+ size_t chars_new_size = chars_old_size;
+ for (; index < end; ++index) {
+ int32_t codeword = data_array[index];
+ chars_new_size += (dict[codeword].size + 1); // extra 1 for zero ending
+ offsets[old_size++] = chars_new_size;
+ }
+
+ // handle chars
+ chars.resize(chars_new_size);
+ unsigned char* c_data = chars.data();
+
+ index = start_index;
Review comment:
```
index = start_index;
for (; index < end; ++index)
```
==>
```for (index = start_index; index < end; ++index)```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1056832065
I will try to test this pr to confirm the performance improvement, it will take some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #8292: (improving) refactor column::insert_many_dict_data
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #8292:
URL: https://github.com/apache/incubator-doris/pull/8292#issuecomment-1060312019
We did a performance test for this pr in SSB, no significant improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org