You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Ted Kirby <te...@gmail.com> on 2008/06/19 06:21:38 UTC
Re: svn commit: r669363 - in /geronimo/devtools/eclipse-plugin/trunk/plugins: org.apache.geronimo.st.core/ org.apache.geronimo.st.ui/ org.apache.geronimo.st.v20.core/ org.apache.geronimo.st.v20.ui/ org.apache.geronimo.st.v21.core/ org.apache.geronimo
No. This notice file adds:
Portions of the Eclipse Geronimo Server Adapter were originally developed by
International Business Machines Corporation and are
licensed to the Apache Software Foundation under the
"Software Grant and Corporate Contribution License Agreement",
informally known as the "Eclipse Geronimo Server Adapter CLA".
This is legacy stuff from 1.0, I believe. There is also this text in
the COPYRIGHT file:
The following copyright notice(s) were affixed to portions of the code
with which this file is now or was at one time distributed
and are placed here unaltered.
/*******************************************************************************
* Copyright (c) 2005 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* IBM Corporation - Initial API and implementation
*******************************************************************************/
I wonder if this COPYRIGHT file could be gotten rid of in light of the
text in the above notice file?
The plugin org.apache.geronimo.runtime.v21 includes geronimo-crypto,
and org.apache.geronimo.runtime.v20 includes the 2.0 equivalent jar
geronimo-util, with bouncy castle notices.
Perhaps I should have opened another JIRA, but what I also did in this
one was try to put the proper notices in each plugin directory, and
then propogate these notices up to the features that include the
various plugins. At present (before JIRA 399), there are two
different and unique notices in all of the plugins: Bouncy Castle, and
the IBM one above. In this commit, I supply the IBM notice in the
applicable plugin directories. I intended everything to come in one
commit, but noticed a bit later I had missed checking in these bits...
And yeah, automating this stuff sounds like a real good idea. I'll
have to look into using the plugins you have referenced.
Thanks!
Ted
On Wed, Jun 18, 2008 at 11:42 PM, Kevan Miller <ke...@gmail.com> wrote:
>
> On Jun 18, 2008, at 10:13 PM, tkirby@apache.org wrote:
>
> Author: tkirby
> Date: Wed Jun 18 19:13:06 200?
> New Revision: 669363
>
> URL: http://svn.apache.org/viewvc?rev=669363&view=rev
> Log:
> GERONIMODEVTOOLS-397 Bouncy Castle License and Notice needs proper exposure
> in GEP files
> add more missed files: notice and license files for each plugin
>
> Added:
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/NOTICE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/NOTICE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v20.core/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v20.core/NOTICE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v20.ui/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v20.ui/NOTICE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v21.core/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v21.core/NOTICE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v21.ui/LICENSE.txt
> (with props)
> geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v21.ui/NOTICE.txt
> (with props)
>
>
> Hi Ted,
> Moving forward, definitely want to start using the
> maven-remote-resources-plugin to automatically install the
> default LICENSE/NOTICE files. See framework/modules/geronimo-crypto for an
> example of how you handle the non-default cases.
> So that I understand, all of these plugins are including the geronimo-crypto
> jar?
> --kevan
Re: svn commit: r669363 - in /geronimo/devtools/eclipse-plugin/trunk/plugins: org.apache.geronimo.st.core/ org.apache.geronimo.st.ui/ org.apache.geronimo.st.v20.core/ org.apache.geronimo.st.v20.ui/ org.apache.geronimo.st.v21.core/ org.apache.geronimo
Posted by Ted Kirby <te...@gmail.com>.
Thanks Kevan. Done in rev 669541.
Ted
On Thu, Jun 19, 2008 at 10:17 PM, Kevan Miller <ke...@gmail.com> wrote:
> I tried to respond to this earlier, but had a machine failure. Pretty sure I
> never got to send...
> On Jun 19, 2008, at 12:21 AM, Ted Kirby wrote:
>
> No. This notice file adds:
>
> Portions of the Eclipse Geronimo Server Adapter were originally developed by
> International Business Machines Corporation and are
> licensed to the Apache Software Foundation under the
> "Software Grant and Corporate Contribution License Agreement",
> informally known as the "Eclipse Geronimo Server Adapter CLA".
>
> This is legacy stuff from 1.0, I believe. There is also this text in
> the COPYRIGHT file:
>
> The following copyright notice(s) were affixed to portions of the code
> with which this file is now or was at one time distributed
> and are placed here unaltered.
>
> /*******************************************************************************
> * Copyright (c) 2005 IBM Corporation and others.
> * All rights reserved. This program and the accompanying materials
> * are made available under the terms of the Eclipse Public License v1.0
> * which accompanies this distribution, and is available at
> * http://www.eclipse.org/legal/epl-v10.html
> *
> * Contributors:
> * IBM Corporation - Initial API and implementation
> *******************************************************************************/
>
> I wonder if this COPYRIGHT file could be gotten rid of in light of the
> text in the above notice file?
>
> Yes, it should not be there. We shouldn't have gotten rid of any copyright
> information when the code was donated. The appropriate place for any
> Copyright statements is the NOTICE file. In general, only the copyright
> holder should move/remove copyright statements. Conveniently, since you work
> for IBM, you can move them... ;-)
> No need to maintain the EPL information from the Copyright statement. The
> code is all, now, ASL V2.0. The specific copyright statement "Copyright (c)
> 2005 IBM Corporation and others." should be moved to the notice statement in
> the NOTICE file.
> --kevan
Re: svn commit: r669363 - in /geronimo/devtools/eclipse-plugin/trunk/plugins: org.apache.geronimo.st.core/ org.apache.geronimo.st.ui/ org.apache.geronimo.st.v20.core/ org.apache.geronimo.st.v20.ui/ org.apache.geronimo.st.v21.core/ org.apache.geronimo
Posted by Kevan Miller <ke...@gmail.com>.
I tried to respond to this earlier, but had a machine failure. Pretty
sure I never got to send...
On Jun 19, 2008, at 12:21 AM, Ted Kirby wrote:
> No. This notice file adds:
>
> Portions of the Eclipse Geronimo Server Adapter were originally
> developed by
> International Business Machines Corporation and are
> licensed to the Apache Software Foundation under the
> "Software Grant and Corporate Contribution License Agreement",
> informally known as the "Eclipse Geronimo Server Adapter CLA".
>
> This is legacy stuff from 1.0, I believe. There is also this text in
> the COPYRIGHT file:
>
> The following copyright notice(s) were affixed to portions of the code
> with which this file is now or was at one time distributed
> and are placed here unaltered.
>
> /
> *******************************************************************************
> * Copyright (c) 2005 IBM Corporation and others.
> * All rights reserved. This program and the accompanying materials
> * are made available under the terms of the Eclipse Public License
> v1.0
> * which accompanies this distribution, and is available at
> * http://www.eclipse.org/legal/epl-v10.html
> *
> * Contributors:
> * IBM Corporation - Initial API and implementation
> *******************************************************************************/
>
> I wonder if this COPYRIGHT file could be gotten rid of in light of the
> text in the above notice file?
Yes, it should not be there. We shouldn't have gotten rid of any
copyright information when the code was donated. The appropriate place
for any Copyright statements is the NOTICE file. In general, only the
copyright holder should move/remove copyright statements.
Conveniently, since you work for IBM, you can move them... ;-)
No need to maintain the EPL information from the Copyright statement.
The code is all, now, ASL V2.0. The specific copyright statement
"Copyright (c) 2005 IBM Corporation and others." should be moved to
the notice statement in the NOTICE file.
--kevan