You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "AlexejTimonin (via GitHub)" <gi...@apache.org> on 2024/07/21 18:47:12 UTC
[PR] [AMQ-9537] Update user-guide.html [activemq]
AlexejTimonin opened a new pull request, #1266:
URL: https://github.com/apache/activemq/pull/1266
Updated things I've noticed that did not work when following the guide:
- Windows example of starting the broker did not work. The broker on windows can be started with activemq.bat start
- Removed the mentions of ANT in the guide, the ANT examples were removed in 5.16.0
- Updated instructions on how to start the broker on windows with web apps.
- Starting broker with the demo apps did not work, updated the configuration to use the config the broker ships with, saved the 5.x demo config for reference.
- Updated in the guide where to change the default credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "AlexejTimonin (via GitHub)" <gi...@apache.org>.
AlexejTimonin commented on code in PR #1266:
URL: https://github.com/apache/activemq/pull/1266#discussion_r1686933958
##########
assembly/src/release/docs/user-guide.html:
##########
@@ -98,7 +98,7 @@ <h2>Access the web demos</h2>
</p>
<pre>
cd bin
- activemq.bat console xbean:examples/conf/activemq-demo.xml
+ activemq.bat start xbean:../examples/conf/activemq-demo.xml
Review Comment:
Thank you for the review!
You are correct that the activemq.bat file does not take any arguments directly, but it does pass the provided arguments to the jar using %*. For reference, see this line:
https://github.com/apache/activemq/blob/6b6f5fbe24550452cd09aab9c4d7094cf782a04f/assembly/src/release/bin/activemq.bat#L99
Running ``activemq.bat`` without ``start`` argument will not start the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1266:
URL: https://github.com/apache/activemq/pull/1266#discussion_r1686831691
##########
assembly/src/release/docs/user-guide.html:
##########
@@ -98,7 +98,7 @@ <h2>Access the web demos</h2>
</p>
<pre>
cd bin
- activemq.bat console xbean:examples/conf/activemq-demo.xml
+ activemq.bat start xbean:../examples/conf/activemq-demo.xml
Review Comment:
NB: `activemq console` is actually valid (at least for Unix shell script). `activemq.bat` doesn't really take any action arg. Maybe we should clean the arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1266:
URL: https://github.com/apache/activemq/pull/1266#discussion_r1686832983
##########
assembly/src/release/examples/conf/jetty-demo-5.x.xml:
##########
@@ -0,0 +1,180 @@
+
+ <!--
+ Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to You under
+ the Apache License, Version 2.0 (the "License"); you may not use this file except in
+ compliance with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or
+ agreed to in writing, software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+ <!--
+ An embedded servlet engine for serving up the Admin consoles, REST and Ajax APIs and
+ some demos Include this file in your configuration to enable ActiveMQ web components
+ e.g. <import resource="jetty.xml"/>
+ -->
+ <beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review Comment:
I would completely remove this file as it's ActiveMQ 5.x specific (not 6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1266:
URL: https://github.com/apache/activemq/pull/1266#issuecomment-2580565655
@jbonofre the jetty-5.x.* files shouldn't have been deleted. These demonstrate how configure Jetty to use a separate JAAS realm, which was the default behavior in ActiveMQ 5.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1266:
URL: https://github.com/apache/activemq/pull/1266#issuecomment-2580577768
But it's ActiveMQ 6 and I tested: it doesn't work anymore with Jetty 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1266:
URL: https://github.com/apache/activemq/pull/1266#issuecomment-2580580913
Ah, ok, That's fine then, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9537] Update user-guide.html [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1266:
URL: https://github.com/apache/activemq/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact