[jira] [Comment Edited] (MPH-183) Effective-pom + verbose should show path to source

["Herve Boutemy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429268#comment-17429268 ] 

Herve Boutemy edited comment on MPH-183 at 3/13/23 6:44 AM:
------------------------------------------------------------

I've attached an integration-test (without verify script!).
In the result.txt you'll notice a line like 
{code:xml}<version>2.1</version>  <!-- org.apache.maven.plugins.help.it:mph183-tool-bom:2.1, line 35 -->{code}
However, if you go through the the parents, you'll never find this dependency: it's defined in the BOM POM, parents only import it.
In the example it is quite clear where it is coming from, but once there are multiple boms, it could be hard to find.

What I would expect is something with "a via" like 
{code:xml}<version>2.1</version>  <!-- org.apache.maven.plugins.help.it:mph183-tool-bom:2.1, line 35 via org.apache.maven.plugins.help.it:mph183-boot-bom:1.0  -->{code}
mph183-boot-bom:1.0 is inherited, which makes it clear where changes should be done.
In theory (and I think with projects like spring-cloud) the level of boms can be even higher, in which case it would be {{x via y via z}}.

Goal is to end the message with a dependency that can be found while going through the parent.



was (Author: rfscholte):
I've attached an integration-test (without verify script!).
In the result.txt you'll notice a line like 
{{<version>2.1</version>  <!-- org.apache.maven.plugins.help.it:mph183-tool-bom:2.1, line 35 -->}}
However, if you go through the the parents, you'll never find this dependency.
In the example it is quite clear where it is coming from, but once there are multiple boms it could be hard to find.

What I would expect is something like 
{{<version>2.1</version>  <!-- org.apache.maven.plugins.help.it:mph183-tool-bom:2.1, line 35 via org.apache.maven.plugins.help.it:mph183-boot-bom:1.0  -->}}
mph183-boot-bom:1.0 is inherited, which makes it clear where changes should be done.
In theory (and I think with projects like spring-cloud) the level of boms can be even higher, in which case it would be {{x via y via z}}.

Goal is to end the message with a dependency that can be found while going through the parent.


> Effective-pom + verbose should show path to source
> --------------------------------------------------
>
>                 Key: MPH-183
>                 URL: https://issues.apache.org/jira/browse/MPH-183
>             Project: Maven Help Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: Robert Scholte
>            Assignee: Maarten Mulders
>            Priority: Major
>         Attachments: mph-183-it.zip
>
>
> The popular spring-boot makes a lot of use of BOMs. Using BOMs is a good practice, but right now it is very hard to determine where dependencies and especially their versions are coming from.
> Instead of only showing only the final location (from the BOM POM), it should also show the path from the current project to that specific pom (where is the BOM POM imported?).
> This way it will be easier to figure out which dependency in which POM needs to be upgraded: it's the version in the POM declaring the import of the BOM POM, not the version in the imported BOM POM.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)