You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 16:00:44 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3942: Consolidate physical join code into `datafusion/core/src/physical_plan/joins`
alamb opened a new pull request, #3942:
URL: https://github.com/apache/arrow-datafusion/pull/3942
# Which issue does this PR close?
Re https://github.com/apache/arrow-datafusion/issues/3941
# Rationale for this change
I want to quickly find where all the join code is (so it is clearer what code needs to be changed) and keep the datafusion codebase cleaner
# What changes are included in this PR?
1. Consolidate physical join code into `datafusion/core/src/physical_plan/joins` following the model of aggregate code:
https://github.com/apache/arrow-datafusion/tree/6e0097d35391fea0d57c1d2ecfdef18437f681f4/datafusion/core/src/physical_plan/aggregates and sorts https://github.com/apache/arrow-datafusion/tree/6e0097d35391fea0d57c1d2ecfdef18437f681f4/datafusion/core/src/physical_plan/sorts
# Are there any user-facing changes?
No functional change intended, this is just a "make the code easier to work with" proposal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3942: Consolidate physical join code into `datafusion/core/src/physical_plan/joins`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3942:
URL: https://github.com/apache/arrow-datafusion/pull/3942#issuecomment-1289501483
Thank you for the review @xudong963 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3942: Consolidate physical join code into `datafusion/core/src/physical_plan/joins`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3942:
URL: https://github.com/apache/arrow-datafusion/pull/3942#issuecomment-1290951155
Benchmark runs are scheduled for baseline = 9595b8d60c9c40aefc514362264c7fa570b563a6 and contender = ff8618a8720b72c581d5e5530f8027b70ce43439. ff8618a8720b72c581d5e5530f8027b70ce43439 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3e14cb2ed9504dfe982bce57e5a751e0...29f0e081f4b44fc7998b9b82031898e4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/928f6f547bae4be292648d37e06b13bb...2075eabc8f204ec5a7a865c1b2fc6dcc/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/47d4fbb7ee254432a38db1fffd7e7a48...2829af4fe33d4e67a7a8f03a666df138/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e9674661c870495bbe9c978115fb3e41...6e0de487097840c4b2d586563f7d9e7c/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3942: Consolidate physical join code into `datafusion/core/src/physical_plan/joins`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3942:
URL: https://github.com/apache/arrow-datafusion/pull/3942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org