You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/04/16 01:10:59 UTC
[native-toolchain-CR] Update README about env setup
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19750
Change subject: Update README about env setup
......................................................................
Update README about env setup
Updates README about how to set up the build environment. Also mentions
the ccache env vars.
Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
---
M README.md
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/19750/1
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] Update README about env setup
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63
PS1, Line 63:
> I'm not sure.. TBO, I haven't made the whole toolchain build succeeded on m
It looked like there's some special code for setting CXX on macOS. Might not be right though.
Also Joe's removing some Darwin-specific flags in https://gerrit.cloudera.org/c/19755/. Not sure if that will hurt or help your efforts.
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 16:30:45 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19750
to look at the new patch set (#3).
Change subject: Update README about env setup
......................................................................
Update README about env setup
Updates README about how to set up the build environment.
Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
---
M README.md
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/19750/3
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] Update README about env setup
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@9
PS1, Line 9: Other platforms might also be supported but are not well tested. To set up the build environment from scratch, refering to the specific docker files, e.g. docker/ubuntu1804.df.
> nit: refering -> refer. Referring expresses the verb as an adjective, where
Could you wrap this line and L19 to keep the 90 char limit?
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 08:47:27 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Update README about env setup
Updates README about how to set up the build environment.
Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Reviewed-on: http://gerrit.cloudera.org:8080/19750
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M README.md
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Daniel Becker: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] Update README about env setup
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@9
PS1, Line 9: Other platforms might also be supported but are not well tested. To set up the build environment from scratch, refering to the specific docker files, e.g. docker/ubuntu1804.df.
nit: refering -> refer. Referring expresses the verb as an adjective, where "To set up..., <do something>" expects a verb.
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63
PS1, Line 63: USE_CCACHE=0 DOWNLOAD_CCACHE=0 SYSTEM_GCC=1 CC=/usr/bin/gcc DEBUG=1 ./buildall.sh
No need to set CXX?
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Apr 2023 16:49:45 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 4: Verified+1
Thank Michael and Daniel!
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 10:16:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@9
PS1, Line 9: Other platforms might also be supported but are not well tested. To set up the
> Could you wrap this line and L19 to keep the 90 char limit?
Done. Thank Michael's explanation!
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63
PS1, Line 63:
> No need to set CXX?
I'm not sure.. TBO, I haven't made the whole toolchain build succeeded on my MacBook. I just played and built some components (trying to set up CLion on MacOS).
This command is the one that can build some components but will still fail at last..
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 18 Apr 2023 09:07:58 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63
PS1, Line 63: and
> It looked like there's some special code for setting CXX on macOS. Might no
Just notice these patches. So we are removing codes about BUILD_HISTORICAL, DOWNLOAD_CCACHE and MacOS. I think we just need the env setup section now.
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 10:26:55 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@9
PS3, Line 9: be supported
I think "might also work" would be better because "supported" implies that we take responsibility for it, which is not the case.
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@21
PS3, Line 21: If you want to build all versions of all packages, you can set the
: environment variable `BUILD_HISTORICAL=1`. Be warned this will take a
: long time.
:
: BUILD_HISTORICAL=1 buildall.sh
The BUILD_HISTORICAL option has been removed by https://gerrit.cloudera.org/#/c/19755/.
Maybe after a rebase it will disappear from here, but let's be careful not to re-introduce it.
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 08:00:41 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 15:34:13 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@9
PS3, Line 9: be supported
> I think "might also work" would be better because "supported" implies that
Done
http://gerrit.cloudera.org:8080/#/c/19750/3/README.md@21
PS3, Line 21: If you want to build all versions of all packages, you can set the
: environment variable `BUILD_HISTORICAL=1`. Be warned this will take a
: long time.
:
: BUILD_HISTORICAL=1 buildall.sh
> The BUILD_HISTORICAL option has been removed by https://gerrit.cloudera.org
Yeah, this disappears after rebase.
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 09:26:14 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19750
to look at the new patch set (#4).
Change subject: Update README about env setup
......................................................................
Update README about env setup
Updates README about how to set up the build environment.
Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
---
M README.md
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/19750/4
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] Update README about env setup
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 04 May 2023 09:58:17 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Update README about env setup
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19750
to look at the new patch set (#2).
Change subject: Update README about env setup
......................................................................
Update README about env setup
Updates README about how to set up the build environment. Also mentions
the ccache env vars.
Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
---
M README.md
1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/50/19750/2
--
To view, visit http://gerrit.cloudera.org:8080/19750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4
Gerrit-Change-Number: 19750
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>