You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/10 10:06:29 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #12721: Even if always compatible is set, Consumers cannot be created
315157973 opened a new pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721
### Motivation
When the Producer's schema is set to AUTO_PRODUCE_BYTES. Even if always compatible is set, Consumers cannot be created. And return Exception `Topic does not have schema to check`
### Documentation
- [ x ] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#discussion_r746510376
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -270,6 +270,9 @@ private void checkCompatible(SchemaAndMetadata existingSchema, SchemaData newSch
@Override
public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData,
SchemaCompatibilityStrategy strategy) {
+ if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(strategy)) {
Review comment:
this is an enum, please use "=="
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#issuecomment-965058406
> over all LGTM
>
> I left one comment
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#issuecomment-965939020
@eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#discussion_r746514279
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -270,6 +270,9 @@ private void checkCompatible(SchemaAndMetadata existingSchema, SchemaData newSch
@Override
public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData,
SchemaCompatibilityStrategy strategy) {
+ if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(strategy)) {
Review comment:
What is the difference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#discussion_r746514279
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -270,6 +270,9 @@ private void checkCompatible(SchemaAndMetadata existingSchema, SchemaData newSch
@Override
public CompletableFuture<Void> checkConsumerCompatibility(String schemaId, SchemaData schemaData,
SchemaCompatibilityStrategy strategy) {
+ if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(strategy)) {
Review comment:
What is the difference ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#discussion_r746438288
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -378,6 +378,9 @@ public String getReplicatorPrefix() {
@Override
public CompletableFuture<Void> checkSchemaCompatibleForConsumer(SchemaData schema) {
+ if (SchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.equals(schemaCompatibilityStrategy)) {
Review comment:
It's better to move into `checkConsumerCompatibility()` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #12721: Even if always compatible is set, Consumers cannot be created
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12721:
URL: https://github.com/apache/pulsar/pull/12721#issuecomment-965053534
over all LGTM
I left one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org